Re: [PATCH v3 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

Maurus Cuelenaere
2010-07-27T16:18:52Z

Op 27-07-10 13:58, Kukjin Kim schreef:
> Maurus Cuelenaere wrote:
>> Op 23-07-10 13:56, Kukjin Kim schreef:
>>> From: Hyuk Lee <hyuk1.lee@samsung.com>
>>>
>>> If host controller doesn't have WP pin which should be connnected with SDMMC
>>> card WP pin, can implement get_ro function with using the allocated gpio.
>>> In order to use this quirk wp_gpio in the platform data must be set.
>>>
>>> Signed-off-by: Hyuk Lee <hyuk1.lee@samsung.com>
>>> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
>>> ---
>>> drivers/mmc/host/sdhci-s3c.c | 43
>> ++++++++++++++++++++++++++++++++++++++++++
>>> drivers/mmc/host/sdhci.c | 3 ++
>>> drivers/mmc/host/sdhci.h | 3 ++
>>> 3 files changed, 49 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
>>> index 0d25285..0b75e57 100644
>>> --- a/drivers/mmc/host/sdhci-s3c.c
>>> +++ b/drivers/mmc/host/sdhci-s3c.c
>>> @@ -22,6 +22,7 @@
>>>
>>> #include <linux/mmc/host.h>
>>>
>>> +#include <plat/gpio-cfg.h>
>>> #include <plat/sdhci.h>
>>> #include <plat/regs-sdhci.h>
>>>
>>> @@ -213,6 +214,36 @@ static void sdhci_s3c_set_clock(struct sdhci_host *host,
>> unsigned int clock)
>>> }
>>>
>>> /**
>>> + * sdhci_s3c_get_ro - callback for get_ro
>>> + * @host: The SDHCI host being changed
>>> + *
>>> + * If the WP pin is connected with GPIO, can get the value which indicates
>>> + * the card is locked or not.
>>> +*/
>>> +static int sdhci_s3c_get_ro(struct mmc_host *mmc)
>>> +{
>>> + struct sdhci_s3c *sc;
>>> + struct sdhci_host *host;
>>> +
>>> + host = mmc_priv(mmc);
>>> + sc = sdhci_priv(host);
>> This can be done as static initializer if you reverse the order above.
> Could you please kindly explain about this?
> Sorry, I cannot get the exactly meaning...

+static int sdhci_s3c_get_ro(struct mmc_host *mmc)
+{
+ struct sdhci_host *host = mmc_priv(mmc);
+ struct sdhci_s3c *sc = sdhci_priv(host);

--
Maurus Cuelenaere