public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Peppe CAVALLARO <peppe.cavallaro@st.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matt Fleming <matt@console-pimps.org>
Subject: Re: [PATCH (mmc-next) 1/3] mmc: add suspend/resume in the sdhci-pltfm driver
Date: Fri, 24 Sep 2010 07:54:53 +0200	[thread overview]
Message-ID: <4C9C3D2D.1090302@st.com> (raw)
In-Reply-To: <1285233266-5039-1-git-send-email-peppe.cavallaro@st.com>

Hello
I wonder if you could review the three patches I sent the mailing list:
especially the following ones:

mmc: add suspend/resume in the sdhci-pltfm driver
mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d.

These follow the advice discussed with Wolfram in the thread named:
  "[PATCH] mmc: add SDHCI driver for STM platforms (V2)."

I just noticed to have forgotten to put in cc Andrew and Matt (sorry).

In fact, I want to remove the stm driver and use the pltfm driver
instead of. To do that on my platforms, I need have the support provided
in these patches. This support could actually be useful for others.

Let me know.

Best Regards,
Peppe

On 09/23/2010 11:14 AM, Giuseppe CAVALLARO wrote:
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/mmc/host/sdhci-pltfm.c | 22 ++++++++++++++++++++++
> 1 files changed, 22 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index e045e3c..89ea64b 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -165,6 +165,24 @@ static const struct platform_device_id sdhci_pltfm_ids[] = {
> };
> MODULE_DEVICE_TABLE(platform, sdhci_pltfm_ids);
> 
> +#ifdef CONFIG_PM
> +static int sdhci_pltfm_suspend(struct platform_device *dev, pm_message_t pm)
> +{
> + struct sdhci_host *host = platform_get_drvdata(dev);
> +
> + sdhci_suspend_host(host, pm);
> + return 0;
> +}
> +
> +static int sdhci_pltfm_resume(struct platform_device *dev)
> +{
> + struct sdhci_host *host = platform_get_drvdata(dev);
> +
> + sdhci_resume_host(host);
> + return 0;
> +}
> +#endif
> +
> static struct platform_driver sdhci_pltfm_driver = {
> .driver = {
> .name = "sdhci",
> @@ -173,6 +191,10 @@ static struct platform_driver sdhci_pltfm_driver = {
> .probe = sdhci_pltfm_probe,
> .remove = __devexit_p(sdhci_pltfm_remove),
> .id_table = sdhci_pltfm_ids,
> +#ifdef CONFIG_PM
> + .suspend = sdhci_pltfm_suspend,
> + .resume = sdhci_pltfm_resume,
> +#endif
> };
> 
> /*****************************************************************************\
> --
> 1.5.5.6
> 

  parent reply	other threads:[~2010-09-24  5:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-23  9:14 [PATCH (mmc-next) 1/3] mmc: add suspend/resume in the sdhci-pltfm driver Giuseppe CAVALLARO
2010-09-23  9:14 ` [PATCH (mmc-next) 2/3] mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d Giuseppe CAVALLARO
2010-09-23  9:14   ` [PATCH (mmc-next) 3/3] mmc: fix a warning when compile the sdhci d.d Giuseppe CAVALLARO
2010-09-27 10:54     ` Wolfram Sang
2010-09-27 12:57       ` Peppe CAVALLARO
2010-09-27 14:17         ` Wolfram Sang
2010-09-27 10:43   ` [PATCH (mmc-next) 2/3] mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d Wolfram Sang
2010-09-27 12:57     ` Peppe CAVALLARO
2010-09-27 14:13       ` Wolfram Sang
2010-09-27 14:20         ` Peppe CAVALLARO
2010-09-27 14:30           ` Wolfram Sang
2010-09-24  5:54 ` Peppe CAVALLARO [this message]
2010-09-24  9:04   ` [PATCH (mmc-next) 1/3] mmc: add suspend/resume in the sdhci-pltfm driver Wolfram Sang
2010-09-24  9:49     ` Peppe CAVALLARO
2010-09-27 10:37 ` Wolfram Sang
2010-09-27 12:57   ` Peppe CAVALLARO
2010-09-27 13:24     ` Peppe CAVALLARO
2010-09-27 14:15       ` Wolfram Sang
2010-09-27 14:25         ` Peppe CAVALLARO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9C3D2D.1090302@st.com \
    --to=peppe.cavallaro@st.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=matt@console-pimps.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox