Re: [PATCH (mmc-next) 2/3] mmc: fix a warning when compile the sdhci d.d. (V2)

Wolfram Sang
2010-09-28T11:09:43Z

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Tue, Sep 28, 2010 at 10:41:28AM +0200, Giuseppe CAVALLARO wrote:
> This patch fixes a warning when compile the sdhci:
> pwr may be used uninitialized in sdhci_set_power
>
> Tested with the following compiler versions: 4.2.4 and 4.4.4
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>

Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>

> ---
> drivers/mmc/host/sdhci.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 96c7f60..d3f924b 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1050,11 +1050,9 @@ out:
>
> static void sdhci_set_power(struct sdhci_host *host, unsigned short power)
> {
> - u8 pwr;
> + u8 pwr = 0;
>
> - if (power == (unsigned short)-1)
> - pwr = 0;
> - else {
> + if (power != (unsigned short)-1) {
> switch (1 << power) {
> case MMC_VDD_165_195:
> pwr = SDHCI_POWER_180;
> --
> 1.5.5.6
>

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]