[PATCH] mmc_rescan: reduce verbosity

[PATCH] mmc_rescan: reduce verbosity

[Eric Bénard]

since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
includes a pr_info which prints 4 lines each second for hosts configured
with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
This patch increase log level to debug (but maybe the right solution
would be to remove this log).

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 drivers/mmc/core/core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index c94565d..6ecfcd9 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -1482,7 +1482,7 @@ void mmc_rescan(struct work_struct *work)
 			mmc_release_host(host);
 			goto out;
 		}
-		pr_info("%s: %s: trying to init card at %u Hz\n",
+		pr_debug("%s: %s: trying to init card at %u Hz\n",
 			mmc_hostname(host), __func__, host->f_init);
 
 		mmc_power_up(host);
-- 
1.7.0.4

Re: [PATCH] mmc_rescan: reduce verbosity

[Nicolas Pitre]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 422 bytes --]

On Mon, 11 Oct 2010, Eric Bénard wrote:

> since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
> includes a pr_info which prints 4 lines each second for hosts configured
> with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
> This patch increase log level to debug (but maybe the right solution
> would be to remove this log).

Indeed.  Flooding the log with debug messages is not much better.


Nicolas

Re: [PATCH] mmc_rescan: reduce verbosity

[Chris Ball]

Hi,

On Mon, Oct 11, 2010 at 09:50:46PM -0400, Nicolas Pitre wrote:
> On Mon, 11 Oct 2010, Eric Bénard wrote:
> > since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
> > includes a pr_info which prints 4 lines each second for hosts configured
> > with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
> > This patch increase log level to debug (but maybe the right solution
> > would be to remove this log).
> 
> Indeed.  Flooding the log with debug messages is not much better.

Other options include:

(a) Turn the message into a DBG().  (CONFIG_MMC_DEBUG=y)
(b) Turn the message into a DBG(), predicated on !MMC_CAP_NEEDS_POLL.
(c) Remove the message.

Any thoughts?  I'll go with (c) unless we agree on a better idea.

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: [PATCH] mmc_rescan: reduce verbosity

[Nicolas Pitre]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1013 bytes --]

On Tue, 12 Oct 2010, Chris Ball wrote:

> Hi,
> 
> On Mon, Oct 11, 2010 at 09:50:46PM -0400, Nicolas Pitre wrote:
> > On Mon, 11 Oct 2010, Eric Bénard wrote:
> > > since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
> > > includes a pr_info which prints 4 lines each second for hosts configured
> > > with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
> > > This patch increase log level to debug (but maybe the right solution
> > > would be to remove this log).
> > 
> > Indeed.  Flooding the log with debug messages is not much better.
> 
> Other options include:
> 
> (a) Turn the message into a DBG().  (CONFIG_MMC_DEBUG=y)
> (b) Turn the message into a DBG(), predicated on !MMC_CAP_NEEDS_POLL.
> (c) Remove the message.
> 
> Any thoughts?  I'll go with (c) unless we agree on a better idea.

My preference would be (a).  You don't lose the intended debugging aid 
but it has to be turned on explicitly.  The people who might care 
most probably have CONFIG_MMC_DEBUG=y already.


Nicolas

Re: [PATCH] mmc_rescan: reduce verbosity

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]

On Mon, Oct 11, 2010 at 11:00:30PM -0400, Nicolas Pitre wrote:
> On Tue, 12 Oct 2010, Chris Ball wrote:
> 
> > Hi,
> > 
> > On Mon, Oct 11, 2010 at 09:50:46PM -0400, Nicolas Pitre wrote:
> > > On Mon, 11 Oct 2010, Eric Bénard wrote:
> > > > since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
> > > > includes a pr_info which prints 4 lines each second for hosts configured
> > > > with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
> > > > This patch increase log level to debug (but maybe the right solution
> > > > would be to remove this log).
> > > 
> > > Indeed.  Flooding the log with debug messages is not much better.
> > 
> > Other options include:
> > 
> > (a) Turn the message into a DBG().  (CONFIG_MMC_DEBUG=y)
> > (b) Turn the message into a DBG(), predicated on !MMC_CAP_NEEDS_POLL.
> > (c) Remove the message.
> > 
> > Any thoughts?  I'll go with (c) unless we agree on a better idea.
> 
> My preference would be (a).  You don't lose the intended debugging aid 
> but it has to be turned on explicitly.  The people who might care 
> most probably have CONFIG_MMC_DEBUG=y already.

+1 There has been a lot of discussion/issues about the initialization
frequency, so this output might be desired in special situations.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[PATCH v2] mmc_rescan: reduce verbosity

[Eric Bénard]

since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
includes a pr_info which prints 4 lines each second for hosts configured
with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
This patch enable the log only if CONFIG_MMC_DEBUG is selected.

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
v2 : enable log only if CONFIG_MMC_DEBUG is selected
v1 : use pr_debug instead of pr_info
 drivers/mmc/core/core.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index c94565d..cda9d29 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -1482,9 +1482,10 @@ void mmc_rescan(struct work_struct *work)
 			mmc_release_host(host);
 			goto out;
 		}
+#ifdef CONFIG_MMC_DEBUG
 		pr_info("%s: %s: trying to init card at %u Hz\n",
 			mmc_hostname(host), __func__, host->f_init);
-
+#endif
 		mmc_power_up(host);
 		sdio_reset(host);
 		mmc_go_idle(host);
-- 
1.7.0.4

Re: [PATCH v2] mmc_rescan: reduce verbosity

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

On Tue, Oct 12, 2010 at 09:29:37AM +0200, Eric Bénard wrote:
> since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
> includes a pr_info which prints 4 lines each second for hosts configured
> with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
> This patch enable the log only if CONFIG_MMC_DEBUG is selected.
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>

Acked-by: Wolfram Sang <w.sang@pengutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH v2] mmc_rescan: reduce verbosity

[Chris Ball]

Hi Eric,

On Tue, Oct 12, 2010 at 09:29:37AM +0200, Eric Bénard wrote:
> since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
> includes a pr_info which prints 4 lines each second for hosts configured
> with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
> This patch enable the log only if CONFIG_MMC_DEBUG is selected.
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> v2 : enable log only if CONFIG_MMC_DEBUG is selected
> v1 : use pr_debug instead of pr_info
>  drivers/mmc/core/core.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index c94565d..cda9d29 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1482,9 +1482,10 @@ void mmc_rescan(struct work_struct *work)
>  			mmc_release_host(host);
>  			goto out;
>  		}
> +#ifdef CONFIG_MMC_DEBUG
>  		pr_info("%s: %s: trying to init card at %u Hz\n",
>  			mmc_hostname(host), __func__, host->f_init);
> -
> +#endif
>  		mmc_power_up(host);
>  		sdio_reset(host);
>  		mmc_go_idle(host);
> -- 

Thanks, applied to mmc-next.

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: [PATCH v2] mmc_rescan: reduce verbosity

[Hein_Tibosch]

 On 12-10-2010 23:08, Chris Ball wrote:
> Hi Eric,
>
> On Tue, Oct 12, 2010 at 09:29:37AM +0200, Eric Bénard wrote:
>> since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
>> includes a pr_info which prints 4 lines each second for hosts configured
>> with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
>> This patch enable the log only if CONFIG_MMC_DEBUG is selected.
>>
>> Signed-off-by: Eric Bénard <eric@eukrea.com>
>> ---
>> v2 : enable log only if CONFIG_MMC_DEBUG is selected
>> v1 : use pr_debug instead of pr_info
>>  drivers/mmc/core/core.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
>> index c94565d..cda9d29 100644
>> --- a/drivers/mmc/core/core.c
>> +++ b/drivers/mmc/core/core.c
>> @@ -1482,9 +1482,10 @@ void mmc_rescan(struct work_struct *work)
>>  			mmc_release_host(host);
>>  			goto out;
>>  		}
>> +#ifdef CONFIG_MMC_DEBUG
>>  		pr_info("%s: %s: trying to init card at %u Hz\n",
>>  			mmc_hostname(host), __func__, host->f_init);
>> -
>> +#endif
I first wrote this line while testing the patch for "configurable ID freq".
I left it in thinking it would only trigger while booting or mounting a
new card, not being aware of the MMC_CAP_NEEDS_POLL option.
Sorry for that,

Acked-by: Hein Tibosch <hein_tibosch@yahoo.es>