* [PATCH -next] mmc: fix cb710 kconfig dependency warning
@ 2010-10-14 1:15 Randy Dunlap
2010-10-14 4:19 ` Chris Ball
2010-10-14 9:04 ` Michał Mirosław
0 siblings, 2 replies; 7+ messages in thread
From: Randy Dunlap @ 2010-10-14 1:15 UTC (permalink / raw)
To: lkml, akpm; +Cc: Chris Ball, MM, linux-mmc
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kconfig dependency warning to satisfy dependencies:
warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct dependencies (MISC_DEVICES && PCI)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: <mirq-linux@rere.qmqm.pl>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20101013.orig/drivers/mmc/host/Kconfig
+++ linux-next-20101013/drivers/mmc/host/Kconfig
@@ -394,7 +394,7 @@ config MMC_TMIO
config MMC_CB710
tristate "ENE CB710 MMC/SD Interface support"
- depends on PCI
+ depends on PCI && MISC_DEVICES
select CB710_CORE
help
This option enables support for MMC/SD part of ENE CB710/720 Flash
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] mmc: fix cb710 kconfig dependency warning
2010-10-14 1:15 [PATCH -next] mmc: fix cb710 kconfig dependency warning Randy Dunlap
@ 2010-10-14 4:19 ` Chris Ball
2010-10-14 9:04 ` Michał Mirosław
1 sibling, 0 replies; 7+ messages in thread
From: Chris Ball @ 2010-10-14 4:19 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, akpm, MM, linux-mmc
Hi Randy,
On Wed, Oct 13, 2010 at 06:15:19PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix kconfig dependency warning to satisfy dependencies:
>
> warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct dependencies (MISC_DEVICES && PCI)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: <mirq-linux@rere.qmqm.pl>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20101013.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20101013/drivers/mmc/host/Kconfig
> @@ -394,7 +394,7 @@ config MMC_TMIO
>
> config MMC_CB710
> tristate "ENE CB710 MMC/SD Interface support"
> - depends on PCI
> + depends on PCI && MISC_DEVICES
> select CB710_CORE
> help
> This option enables support for MMC/SD part of ENE CB710/720 Flash
Thanks very much, pushed to mmc-next.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] mmc: fix cb710 kconfig dependency warning
2010-10-14 1:15 [PATCH -next] mmc: fix cb710 kconfig dependency warning Randy Dunlap
2010-10-14 4:19 ` Chris Ball
@ 2010-10-14 9:04 ` Michał Mirosław
2010-10-14 15:46 ` Randy Dunlap
2010-10-14 18:30 ` [PATCH -next v2] " Randy Dunlap
1 sibling, 2 replies; 7+ messages in thread
From: Michał Mirosław @ 2010-10-14 9:04 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, akpm, Chris Ball, linux-mmc
On Wed, Oct 13, 2010 at 06:15:19PM -0700, Randy Dunlap wrote:
> Fix kconfig dependency warning to satisfy dependencies:
>
> warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct dependencies (MISC_DEVICES && PCI)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: <mirq-linux@rere.qmqm.pl>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20101013.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20101013/drivers/mmc/host/Kconfig
> @@ -394,7 +394,7 @@ config MMC_TMIO
>
> config MMC_CB710
> tristate "ENE CB710 MMC/SD Interface support"
> - depends on PCI
> + depends on PCI && MISC_DEVICES
> select CB710_CORE
> help
> This option enables support for MMC/SD part of ENE CB710/720 Flash
Is this really necessary? MISC_DEVICES is only a submenu enabler, not
a real dependency.
Maybe just select MISC_DEVICES instead? User/developer should not have
to know that for this specific MMC controller he has to first enable some
other device burried somewhere in the config tree.
Best Regards,
Michał Mirosław
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] mmc: fix cb710 kconfig dependency warning
2010-10-14 9:04 ` Michał Mirosław
@ 2010-10-14 15:46 ` Randy Dunlap
2010-10-14 18:30 ` [PATCH -next v2] " Randy Dunlap
1 sibling, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2010-10-14 15:46 UTC (permalink / raw)
To: Michał Mirosław; +Cc: lkml, akpm, Chris Ball, linux-mmc
On 10/14/10 02:04, Michał Mirosław wrote:
> On Wed, Oct 13, 2010 at 06:15:19PM -0700, Randy Dunlap wrote:
>> Fix kconfig dependency warning to satisfy dependencies:
>>
>> warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct dependencies (MISC_DEVICES && PCI)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: <mirq-linux@rere.qmqm.pl>
>> ---
>> drivers/mmc/host/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20101013.orig/drivers/mmc/host/Kconfig
>> +++ linux-next-20101013/drivers/mmc/host/Kconfig
>> @@ -394,7 +394,7 @@ config MMC_TMIO
>>
>> config MMC_CB710
>> tristate "ENE CB710 MMC/SD Interface support"
>> - depends on PCI
>> + depends on PCI && MISC_DEVICES
>> select CB710_CORE
>> help
>> This option enables support for MMC/SD part of ENE CB710/720 Flash
>
> Is this really necessary? MISC_DEVICES is only a submenu enabler, not
> a real dependency.
>
> Maybe just select MISC_DEVICES instead? User/developer should not have
> to know that for this specific MMC controller he has to first enable some
> other device burried somewhere in the config tree.
Yes, I'll resubmit using "select". (like I did with another mmc + memstick patch)
thanks,
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH -next v2] mmc: fix cb710 kconfig dependency warning
2010-10-14 9:04 ` Michał Mirosław
2010-10-14 15:46 ` Randy Dunlap
@ 2010-10-14 18:30 ` Randy Dunlap
2010-10-14 19:27 ` Chris Ball
2010-10-14 19:50 ` Michał Mirosław
1 sibling, 2 replies; 7+ messages in thread
From: Randy Dunlap @ 2010-10-14 18:30 UTC (permalink / raw)
To: Michał Mirosław; +Cc: lkml, akpm, Chris Ball, linux-mmc
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kconfig dependency warning to satisfy dependencies:
warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct dependencies (MISC_DEVICES && PCI)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: <mirq-linux@rere.qmqm.pl>
---
drivers/mmc/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20101013.orig/drivers/mmc/host/Kconfig
+++ linux-next-20101013/drivers/mmc/host/Kconfig
@@ -395,6 +395,7 @@ config MMC_TMIO
config MMC_CB710
tristate "ENE CB710 MMC/SD Interface support"
depends on PCI
+ select MISC_DEVICES
select CB710_CORE
help
This option enables support for MMC/SD part of ENE CB710/720 Flash
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next v2] mmc: fix cb710 kconfig dependency warning
2010-10-14 18:30 ` [PATCH -next v2] " Randy Dunlap
@ 2010-10-14 19:27 ` Chris Ball
2010-10-14 19:50 ` Michał Mirosław
1 sibling, 0 replies; 7+ messages in thread
From: Chris Ball @ 2010-10-14 19:27 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Michał Mirosław, lkml, akpm, linux-mmc
Hi,
On Thu, Oct 14, 2010 at 11:30:55AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix kconfig dependency warning to satisfy dependencies:
>
> warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct dependencies (MISC_DEVICES && PCI)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: <mirq-linux@rere.qmqm.pl>
> ---
> drivers/mmc/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20101013.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20101013/drivers/mmc/host/Kconfig
> @@ -395,6 +395,7 @@ config MMC_TMIO
> config MMC_CB710
> tristate "ENE CB710 MMC/SD Interface support"
> depends on PCI
> + select MISC_DEVICES
> select CB710_CORE
> help
> This option enables support for MMC/SD part of ENE CB710/720 Flash
> --
Thanks, carrying this version in mmc-next now.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next v2] mmc: fix cb710 kconfig dependency warning
2010-10-14 18:30 ` [PATCH -next v2] " Randy Dunlap
2010-10-14 19:27 ` Chris Ball
@ 2010-10-14 19:50 ` Michał Mirosław
1 sibling, 0 replies; 7+ messages in thread
From: Michał Mirosław @ 2010-10-14 19:50 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, akpm, Chris Ball, linux-mmc
On Thu, Oct 14, 2010 at 11:30:55AM -0700, Randy Dunlap wrote:
> Fix kconfig dependency warning to satisfy dependencies:
> warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct dependencies (MISC_DEVICES && PCI)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: <mirq-linux@rere.qmqm.pl>
> ---
> drivers/mmc/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20101013.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20101013/drivers/mmc/host/Kconfig
> @@ -395,6 +395,7 @@ config MMC_TMIO
> config MMC_CB710
> tristate "ENE CB710 MMC/SD Interface support"
> depends on PCI
> + select MISC_DEVICES
> select CB710_CORE
> help
> This option enables support for MMC/SD part of ENE CB710/720 Flash
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
It would be better, thoughm if MISC_DEVICES was some kind of ghost config
entry that needs no selecting or depending on as it is used only for users
convenience - config tree decoration maybe.
Best Regards,
Michał Mirosław
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-10-14 19:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-14 1:15 [PATCH -next] mmc: fix cb710 kconfig dependency warning Randy Dunlap
2010-10-14 4:19 ` Chris Ball
2010-10-14 9:04 ` Michał Mirosław
2010-10-14 15:46 ` Randy Dunlap
2010-10-14 18:30 ` [PATCH -next v2] " Randy Dunlap
2010-10-14 19:27 ` Chris Ball
2010-10-14 19:50 ` Michał Mirosław
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).