Re: [PATCH] mmc: agressive clocking framework v9

[David Vrabel <david.vrabel@csr.com>]

Linus Walleij wrote:
> 
> Switch to grouping this with the runtime PM stuff as Alan
> suggested. Is this looking better?
> [...]
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
> index af8dc6a..9064def 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -148,14 +148,19 @@ static int mmc_runtime_suspend(struct device *dev)
>  {
>  	struct mmc_card *card = mmc_dev_to_card(dev);
>  
> +	mmc_gate_clock(card->host);
>  	return mmc_power_save_host(card->host);
>  }

Haven't you tied the clock gating to the power on/off state of the
card/host?  This looks like the wrong thing to me.  Surely we want to
gate the clock even if the card (or SDIO functions) are active?

David--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom