Re: [PATCH 2/5] mmc: do not clear the host->pm_flags when suspend

Nicolas Pitre
2010-11-12T04:37:06Z

On Wed, 10 Nov 2010, Giuseppe CAVALLARO wrote:

> HC driver will be able to use the pm_flags to
> undestand if the system can be woken-up by the driver.
> So the mmc_suspend_host hasn't to reset this field
> in the host structure.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/mmc/core/core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 569e94d..6d2d6e4 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1276,7 +1276,6 @@ int mmc_suspend_host(struct mmc_host *host)
> mmc_claim_host(host);
> mmc_detach_bus(host);
> mmc_release_host(host);
> - host->pm_flags = 0;
> err = 0;
> }
> }

This is wrong. The host->pm_flags are set by SDIO function drivers to
indicate they want the host controller to keep card power on when the
host system is going to sleep. In this case, the card has been removed,
and therefore any flag is invalid and should be cleared.

Nicolas