Re: [PATCH 2/5] mmc: do not clear the host->pm_flags when suspend

Ohad Ben-Cohen
2010-11-10T20:28:33Z

Hi Giuseppe,

On Wed, Nov 10, 2010 at 5:28 PM, Giuseppe CAVALLARO
<peppe.cavallaro@st.com> wrote:
> HC driver will be able to use the pm_flags to
> undestand if the system can be woken-up by the driver.
> So the mmc_suspend_host hasn't to reset this field
> in the host structure.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
>  drivers/mmc/core/core.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 569e94d..6d2d6e4 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1276,7 +1276,6 @@ int mmc_suspend_host(struct mmc_host *host)
>                        mmc_claim_host(host);
>                        mmc_detach_bus(host);
>                        mmc_release_host(host);
> -                       host->pm_flags = 0;

This is elapsed because the card is removed at this point (e.g. SDIO
returned -ENOSYS).

Why would you want to use flags, set by a function driver of an SDIO
card, that was just removed ?

>                        err = 0;
>                }
>        }
> --
> 1.5.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>