From: Rob Herring <robherring2@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 4/7] mmc: sdhci-of: fix build on non-powerpc platforms
Date: Tue, 16 Nov 2010 16:34:56 -0600 [thread overview]
Message-ID: <4CE30710.6050302@gmail.com> (raw)
In-Reply-To: <20101116214409.GC19893@pengutronix.de>
On 11/16/2010 03:44 PM, Wolfram Sang wrote:
> On Tue, Nov 16, 2010 at 02:33:52PM -0600, Rob Herring wrote:
>> From: Rob Herring<rob.herring@calxeda.com>
>>
>> Explicitly include err.h, of_address.h and of_irq.h.
>> Make use of machine_is() conditional on PPC.
>>
>> Signed-off-by: Rob Herring<rob.herring@calxeda.com>
>
> Hmm, sins of the past :/ I wonder if we can get away with less #ifdeffery, will
> think about it...
>
I don't want to start a long debate, but is updating a kernel without
updating the dtb really something to worry about? Isn't a year enough of
a transition period.
Do these machines have a machine level compatible property that could be
used instead?
Rob
next prev parent reply other threads:[~2010-11-16 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1289939635-30742-1-git-send-email-robherring2@gmail.com>
[not found] ` <1289939635-30742-6-git-send-email-robherring2@gmail.com>
2010-11-16 21:32 ` [PATCH 5/7] mmc: sdhci-of: support generic OF controllers Wolfram Sang
[not found] ` <1289939635-30742-5-git-send-email-robherring2@gmail.com>
2010-11-16 21:44 ` [PATCH 4/7] mmc: sdhci-of: fix build on non-powerpc platforms Wolfram Sang
2010-11-16 22:34 ` Rob Herring [this message]
2010-11-17 5:32 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE30710.6050302@gmail.com \
--to=robherring2@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox