From: Jaehoon Chung <jh80.chung@samsung.com>
To: Philip Rakity <prakity@marvell.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
kyungmin Park <kyungmin.park@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
"matt@console-pimps.org" <matt@console-pimps.org>
Subject: Re: [RFC Patch] SDHCI: add quirk for data timeout value when card busy.
Date: Wed, 01 Dec 2010 14:44:58 +0900 [thread overview]
Message-ID: <4CF5E0DA.3060300@samsung.com> (raw)
In-Reply-To: <43E4817426ED174AA81263BCECB4351D13200C545E@sc-vexch3.marvell.com>
Philip Rakity wrote:
> Can we just remove the quirk for broken timeout and just set the timeout to 0xe in sdhci.c?
you means that set the timeout to 0xe without broken timeout in sdhci.c?
>
> The problem with the quirk is you need to know when to set it and the problem with the existing quirk is that one has to set it to work with bad cards.
I know when use quirk...and what use one...
> ________________________________________
> From: linux-mmc-owner@vger.kernel.org [linux-mmc-owner@vger.kernel.org] On Behalf Of Jaehoon Chung [jh80.chung@samsung.com]
> Sent: Tuesday, November 30, 2010 3:37 AM
> To: Wolfram Sang
> Cc: linux-mmc@vger.kernel.org; Chris Ball; kyungmin Park; Andrew Morton; matt@console-pimps.org
> Subject: Re: [RFC Patch] SDHCI: add quirk for data timeout value when card busy.
>
>>> Maybe, happen for all sdhci-controllers...
>> My point is: If it is needed for all SDHCI-controllers, we don't need a
>> quirk and can apply your code unconditionally.
>>
>
> You're right. But i'm not sure, happen for all sdhci-controller.
> so i send to RFC patch..
> I also hope apply my code unconditionally.
>
> the reason using quirk...every card didn't happen this issue..
> if not happen this issue, we need not set timeout value..at that time..
>
> when needs, entered and set timeout value..(conditionally)
>
>
>>> Card is configurable with eMMC spec..But sdhci-controller didn't
>>> support that card. So SDHCI controller need to use quriks..
>> Can we find out if this is a general issue?
>>
>
> Hmm..i'm sure you can find out this issue..
> Have ever find out this issue(similar case)..anybody?
>
>> Regards,
>>
>> Wolfram
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-12-01 5:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 6:13 [RFC Patch] SDHCI: add quirk for data timeout value when card busy Jaehoon Chung
2010-11-30 6:42 ` Philip Rakity
2010-11-30 7:15 ` Jaehoon Chung
2010-11-30 9:56 ` Wolfram Sang
2010-11-30 10:13 ` Jaehoon Chung
2010-11-30 10:54 ` Wolfram Sang
2010-11-30 11:37 ` Jaehoon Chung
2010-11-30 15:56 ` Philip Rakity
2010-12-01 5:44 ` Jaehoon Chung [this message]
2010-12-01 5:51 ` Philip Rakity
2010-12-01 12:29 ` Jaehoon Chung
2010-12-01 16:21 ` Philip Rakity
2010-12-02 7:40 ` Jaehoon Chung
2010-12-02 9:09 ` Wolfram Sang
2010-12-02 16:00 ` Philip Rakity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF5E0DA.3060300@samsung.com \
--to=jh80.chung@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=prakity@marvell.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox