From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v3] mmc: davinci: add support for SDIO irq handling Date: Thu, 30 Dec 2010 15:42:01 +0300 Message-ID: <4D1C7E19.7050605@mvista.com> References: <1293706357-21358-1-git-send-email-nsekhar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:38601 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813Ab0L3MnG (ORCPT ); Thu, 30 Dec 2010 07:43:06 -0500 Received: by ewy5 with SMTP id 5so5071814ewy.19 for ; Thu, 30 Dec 2010 04:43:04 -0800 (PST) In-Reply-To: <1293706357-21358-1-git-send-email-nsekhar@ti.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Sekhar Nori Cc: linux-mmc@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com, Chris Ball Hello. On 30-12-2010 13:52, Sekhar Nori wrote: > From: Alagu Sankar > This patch adds support for handing SDIO interrupt on > DaVinci MMC/SD controller. > The patch has been tested on DM355 and DA850 EVMs with > Marvell Libertas based SDIO wireless LAN card. > Signed-off-by: Alagu Sankar > Signed-off-by: Sekhar Nori [...] > diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c > index b643dde..04c2fa4 100644 > --- a/drivers/mmc/host/davinci_mmc.c > +++ b/drivers/mmc/host/davinci_mmc.c [...] > @@ -1209,7 +1267,8 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev) > host->nr_sg = MAX_NR_SG; > > host->use_dma = use_dma; > - host->irq = irq; > + host->mmc_irq = irq; > + host->sdio_irq = platform_get_irq(pdev, 1); > > if (host->use_dma&& davinci_acquire_dma_channels(host) != 0) > host->use_dma = 0; > @@ -1270,6 +1329,13 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev) > if (ret) > goto out; > > + if (host->sdio_irq != NO_IRQ) { Note that platform_get_irq() will return -EXDEV if the resource is not present. Perhaps you should check for it... WBR, Sergei