From: David Vrabel <david.vrabel@csr.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 3/4] mmc: add MMC_QUIRK_DISABLE_CD
Date: Tue, 04 Jan 2011 23:04:52 +0000 [thread overview]
Message-ID: <4D23A794.8020106@csr.com> (raw)
In-Reply-To: <AANLkTinEWsYBqgchwbjT2ZnoVYPcibJDF2Jt3v1AysUt@mail.gmail.com>
On 04/01/2011 22:27, Ohad Ben-Cohen wrote:
> On Wed, Jan 5, 2011 at 12:13 AM, Ohad Ben-Cohen <ohad@wizery.com> wrote:
>>> Whether this pull up should be
>>> enabled or disabled is determined by the board (not the card). The
>>> pull-up should be disabled if the board has a pull-up external to the
>>> card, otherwise it must remain enabled.
>>
>> Agree.
>
> It might make more sense to use a host CAP though for this (i.e.
> MMC_CAP_DISABLE_CD).
Could we unconditionally disable the card's internal pull-up? A board
that's using DAT3 for card detection should have a switchable pull-down
/and/ a switchable pull-up.
This would cause regressions on boards that aren't properly designed and
have omitted the pull-up. Are there boards like this?
David
next prev parent reply other threads:[~2011-01-04 23:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 21:10 [PATCH 1/4] mmc: mmc_card_keep_power cleanups Ohad Ben-Cohen
2011-01-04 21:10 ` [PATCH 2/4] mmc: do not switch to 1-bit mode if not required Ohad Ben-Cohen
2011-01-04 21:10 ` [PATCH 3/4] mmc: add MMC_QUIRK_DISABLE_CD Ohad Ben-Cohen
2011-01-04 22:09 ` David Vrabel
2011-01-04 22:13 ` Ohad Ben-Cohen
2011-01-04 22:27 ` Ohad Ben-Cohen
2011-01-04 23:04 ` David Vrabel [this message]
2011-01-04 23:22 ` Ohad Ben-Cohen
2011-01-06 23:40 ` Ohad Ben-Cohen
2011-01-04 21:10 ` [PATCH 4/4] mmc: add MMC_QUIRK_NONSTD_FUNC_IF Ohad Ben-Cohen
2011-01-04 22:48 ` Pierre Tardy
2011-01-04 23:16 ` Ohad Ben-Cohen
2011-01-04 23:25 ` Pierre Tardy
2011-01-04 23:34 ` Ohad Ben-Cohen
2011-01-05 9:10 ` Pierre Tardy
2011-01-05 9:40 ` Ohad Ben-Cohen
2011-01-05 12:28 ` Pierre Tardy
2011-01-06 23:16 ` Ohad Ben-Cohen
2011-01-09 16:48 ` Pierre Tardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D23A794.8020106@csr.com \
--to=david.vrabel@csr.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox