public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@csr.com>
To: Chris Ball <cjb@laptop.org>
Cc: Tony Olech <tony.olech@elandigitalsystems.com>,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver
Date: Thu, 06 Jan 2011 13:18:21 +0000	[thread overview]
Message-ID: <4D25C11D.5020205@csr.com> (raw)
In-Reply-To: <20110106045611.GB17617@void.printf.net>

Chris Ball wrote:
> Hi David,
> 
> On Tue, Dec 21, 2010 at 03:03:58PM +0000, Tony Olech wrote:
>>>> Any interest in reviewing this USB-SD driver?  I'm especially curious
>>>> about whether you think there are worthwhile possibilities to share
>>>> code with USHC.
>>> A quick look suggests that there is unlikely to be any commonality
>>> between the two drivers.
>>>
>>> Tony, where can I find the datasheet or developer's manual describing
>>> the protocol/operation of this chip?
>> I finally persuaded my boss that our interface document should put released.
>> It is the PDF in  
>> http://www.elandigitalsystems.com/eng/drivers/vub300/Linux-v2-10.zip
>> and it describes the protocol between the customized SMSC chip and the  
>> host PC.
>> And I agree that there will be virtually nothing in common with the USHC  
>> driver.
> 
> Might you be able to find time to review this soon?

There is no useful commonality between this driver and the USHC driver.
 I don't have time to do a detailed code review but I have gone through
and highlighted some potential issues (see other email).

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom

  reply	other threads:[~2011-01-06 14:24 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20B0EAA71DD7413A9A29D0493C6C1D87@AN00536>
     [not found] ` <20101116150022.GA27726@void.printf.net>
     [not found]   ` <27884BED0E3C489C8849EE12A803F536@AN00536>
     [not found]     ` <m3oc9pnt6g.fsf@pullcord.laptop.org>
     [not found]       ` <4CE41BE3.1060806@elandigitalsystems.com>
     [not found]         ` <m3oc9n241c.fsf@pullcord.laptop.org>
2010-11-22 15:05           ` [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Tony Olech
2010-11-30  6:15             ` Chris Ball
2010-11-30 12:23               ` David Vrabel
2010-12-17  0:43                 ` Chris Ball
2010-12-21 15:03                 ` Tony Olech
2011-01-06  4:56                   ` Chris Ball
2011-01-06 13:18                     ` David Vrabel [this message]
2011-01-06 13:17             ` David Vrabel
2011-01-20 16:09               ` Tony Olech
2011-01-20 16:11               ` Tony Olech
2011-01-21 10:50             ` [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission Tony Olech
2011-01-21 21:14               ` Nicolas Pitre
2011-01-22 14:21                 ` Wolfram Sang
2011-01-22 19:07                   ` Nicolas Pitre
2011-01-23 10:09                     ` Wolfram Sang
2011-01-23 14:01                       ` Nicolas Pitre
2011-01-24 15:35                         ` Wolfram Sang
2011-01-24 16:27                         ` Tony Olech
2011-01-24 16:21                       ` Tony Olech
2011-01-25  9:13                         ` Wolfram Sang
2011-01-25  9:35                           ` Tony Olech
2011-01-25 20:40                             ` Nicolas Pitre
2011-01-24 16:17                     ` Tony Olech
2011-01-24  8:49                 ` Tony Olech
2011-01-24 14:43                   ` Nicolas Pitre
2011-01-24 15:10                     ` Tony Olech
2011-01-24 15:55                       ` Nicolas Pitre
2011-01-24 16:08                         ` Tony Olech
2011-01-24 16:28                           ` Nicolas Pitre
2011-01-24 16:43                             ` Tony Olech
2011-03-10 16:13               ` [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission Tony Olech
2011-03-15  3:01                 ` Chris Ball
2011-03-15  9:40                   ` Wolfram Sang
2011-03-15 15:06                     ` Chris Ball
2011-03-15 15:41                       ` Arnd Bergmann
2011-03-15 16:23                 ` Arnd Bergmann
2011-03-15 16:55                   ` Tony Olech
2011-04-19  9:05                   ` Tony Olech
2011-04-19 12:10                     ` Arnd Bergmann
2011-04-19 12:32                       ` Tony Olech
2011-04-19 13:21                         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D25C11D.5020205@csr.com \
    --to=david.vrabel@csr.com \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tony.olech@elandigitalsystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox