Re: [PATCH v4] dw_mmc: Add Synopsys DesignWare mmc host driver.

Jaehoon Chung
2011-02-08T10:49:33Z

Hi Will

I'm probing dw_mmc on Samsung SoC...

So i have some board specific data..

But i didn't want to add board specific data in dw_mmc.c
I want to use get_cd()/get_wd()/init()...So i asked to you..:)

If i need not the data information, i will not append them..
you're right, maybe "struct dw_mci" need not..(just example)

And i think that need card_detect irq-handler function..if we use pdata->init..isn't? :)

In future, if i need your help, can i ask to you?

Onemore...Did you test the dw_mmc..?
If you can answer, i want to know the performance..

Will Newton wrote:
> On Tue, Feb 8, 2011 at 6:38 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> Hi Will..
>>
>> I need your help for your code..
>>
>> In dw_mmc.h, exist some function pointer..
>>
>> int *get_ro(u32 slot_id);
>> int *get_cd(u32 slot_id);
>> ...
>>
>> Just only need slot_id??
>> If i need the "struct dw_mci", could i append the parameter?
>
> Yes, that should be possible. However I would like to reduce the
> number of places the whole struct dw_mci
> is passed around if possible, as the whole struct is usually not
> needed and it exposes some driver internals.
>
> Which part of struct dw_mci do you need in the callback?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>