From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms Date: Fri, 21 Jan 2011 14:11:46 -0200 Message-ID: <4D39B042.5050004@freescale.com> References: <1295542979-10329-1-git-send-email-fabio.estevam@freescale.com> <20110121153351.GR14956@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from am1ehsobe004.messaging.microsoft.com ([213.199.154.207]:27388 "EHLO AM1EHSOBE004.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088Ab1AUQMD convert rfc822-to-8bit (ORCPT ); Fri, 21 Jan 2011 11:12:03 -0500 In-Reply-To: <20110121153351.GR14956@pengutronix.de> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: =?ISO-8859-1?Q?Uwe_Kleine-K=F6nig?= Cc: linux-mmc@vger.kernel.org, cjb@laptop.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Hi Uwe, On 1/21/2011 1:33 PM, Uwe Kleine-K=F6nig wrote: > Hallo, >=20 > On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote: >> Currently MMC_MXC driver can be selected by all i.MX devices. >> >> Restrict its use only for the appropriate processors. >> >> Signed-off-by: Fabio Estevam >> --- >> drivers/mmc/host/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >> index d618e86..a3a9ec1 100644 >> --- a/drivers/mmc/host/Kconfig >> +++ b/drivers/mmc/host/Kconfig >> @@ -288,7 +288,7 @@ config MMC_MSM >> =20 >> config MMC_MXC >> tristate "Freescale i.MX2/3 Multimedia Card Interface support" >> - depends on ARCH_MXC >> + depends on MACH_MX21 || MACH_MX27 || ARCH_MX31 > What about >=20 > depends IMX_HAVE_PLATFORM_MXC_MMC I would prefer to let the architectures explicitly in Kconfig. If someone selects IMX_HAVE_PLATFORM_MXC_MMC by mistake on a MX51 board= , it will be possible to select the MXC_MMC driver in the kernel for MX= 51, which is incorrect. Using the approach of explicitly marking the architectures that support= MXC_MMC would avoid such problems as well. >=20 > ? Then if i.MX29 has the same IP you don't need to touch this again. Not likely to happen.=20 Thanks, =46abio Estevam