public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
	Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 03/11] atmel-mci: use dmaengine helper functions
Date: Thu, 10 Feb 2011 16:18:54 +0100	[thread overview]
Message-ID: <4D5401DE.5050506@atmel.com> (raw)
In-Reply-To: <1297350506-1522-1-git-send-email-linus.walleij@linaro.org>

Le 10/02/2011 16:08, Linus Walleij :
> Use the new dmaengine helpers to make the code more readable.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---

Thanks for this update Linus! (That was on my todo list ;-))

Best regards,

>  drivers/mmc/host/atmel-mci.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index df5a135..80bc9a5 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -589,7 +589,7 @@ static void atmci_stop_dma(struct atmel_mci *host)
>  	struct dma_chan *chan = host->data_chan;
>  
>  	if (chan) {
> -	  chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
> +		dmaengine_terminate_all(chan);
>  		atmci_dma_cleanup(host);
>  	} else {
>  		/* Data transfer was stopped by the interrupt handler */
> @@ -710,8 +710,8 @@ static void atmci_submit_data(struct atmel_mci *host)
>  	struct dma_async_tx_descriptor	*desc = host->dma.data_desc;
>  
>  	if (chan) {
> -		desc->tx_submit(desc);
> -		chan->device->device_issue_pending(chan);
> +		dmaengine_submit(desc);
> +		dma_async_issue_pending(chan);
>  	}
>  }
>  


-- 
Nicolas Ferre

      reply	other threads:[~2011-02-10 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10 15:08 [PATCH 03/11] atmel-mci: use dmaengine helper functions Linus Walleij
2011-02-10 15:18 ` Nicolas Ferre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5401DE.5050506@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=cjb@laptop.org \
    --cc=dan.j.williams@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox