Re: [PATCH] dw_mmc: modify quirks bit-shift control

[Jaehoon Chung <jh80.chung@samsung.com>]

Hi..

> Why skip (1 << 1)?  (There's also BIT(0) -> BIT(2) if you prefer.)

My mistake..sorry..and thanks for your comment..
I resend the patch applied BIT(0)-BIT(2)

Thanks,
Jaehoon Chung


Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 include/linux/mmc/dw_mmc.h |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
index 16b0261..3f22c20 100644
--- a/include/linux/mmc/dw_mmc.h
+++ b/include/linux/mmc/dw_mmc.h
@@ -165,14 +165,12 @@ struct dw_mci_dma_ops {
 };
 
 /* IP Quirks/flags. */
-/* No special quirks or flags to cater for */
-#define DW_MCI_QUIRK_NONE		0
 /* DTO fix for command transmission with IDMAC configured */
-#define DW_MCI_QUIRK_IDMAC_DTO		1
+#define DW_MCI_QUIRK_IDMAC_DTO		BIT(0)
 /* delay needed between retries on some 2.11a implementations */
-#define DW_MCI_QUIRK_RETRY_DELAY	2
+#define DW_MCI_QUIRK_RETRY_DELAY	BIT(1)
 /* High Speed Capable - Supports HS cards (upto 50MHz) */
-#define DW_MCI_QUIRK_HIGHSPEED		4
+#define DW_MCI_QUIRK_HIGHSPEED		BIT(2)
 
 
 struct dma_pdata;
-- 
1.6.0.4