From: Jaehoon Chung <jh80.chung@samsung.com>
To: Will Newton <will.newton@gmail.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] dw_mmc: set the debounce value and remove duplicated offset
Date: Tue, 22 Feb 2011 11:18:04 +0900 [thread overview]
Message-ID: <4D631CDC.2060702@samsung.com> (raw)
In-Reply-To: <AANLkTi=Vv8=7FwArQPwjXPZ93YoE7uKvyR-0Ze81Lmbn@mail.gmail.com>
Will Newton wrote:
> On Mon, Feb 21, 2011 at 8:57 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> This patch is set the debouce value..
>> This value do not need to be changed with every command.
>> So we set the value in probe function.
>>
>> And DATA register offset is duplicated..
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> drivers/mmc/host/dw_mmc.c | 3 +++
>> drivers/mmc/host/dw_mmc.h | 1 -
>> 2 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index 62c8440..b3f94ff 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -1623,6 +1623,9 @@ static int dw_mci_probe(struct platform_device *pdev)
>> /* Put in max timeout */
>> mci_writel(host, TMOUT, 0xFFFFFFFF);
>>
>> + /* Set the debounce value */
>> + mci_writel(host, DEBNCE, 0xFFFFFF);
>> +
>
> As I understand it this is the reset value of the DEBNCE register? Why
> do we need to set it at all?
If need to set other value, we can change the debounce value (5~25ms).
This value is default reset value.
>
>> /*
>> * FIFO threshold settings RxMark = fifo_size / 2 - 1,
>> * Tx Mark = fifo_size / 2 DMA Size = 8
>> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
>> index 5dd55a7..f492837 100644
>> --- a/drivers/mmc/host/dw_mmc.h
>> +++ b/drivers/mmc/host/dw_mmc.h
>> @@ -51,7 +51,6 @@
>> #define SDMMC_DSCADDR 0x094
>> #define SDMMC_BUFADDR 0x098
>> #define SDMMC_DATA 0x100
>> -#define SDMMC_DATA_ADR 0x100
>
> This part is fine.
>
> Acked-by: Will Newton <will.newton@imgtec.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2011-02-22 2:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 8:57 [PATCH] dw_mmc: set the debounce value and remove duplicated offset Jaehoon Chung
2011-02-21 10:23 ` Will Newton
2011-02-22 2:18 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D631CDC.2060702@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox