[PATCH] mmc: dw_mmc: Remove set-but-unused variable.

[PATCH] mmc: dw_mmc: Remove set-but-unused variable.

[Chris Ball]

count is only ever used by assigning to old_len if count == 0, and
then old_len isn't ever used at all.  So, both are redundant.  Fixes:

drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_read_data_pio’:
drivers/mmc/host/dw_mmc.c:1034:32: warning: variable ‘old_len’ set but
not used [-Wunused-but-set-variable]

Signed-off-by: Chris Ball <cjb@laptop.org>
Cc: Will Newton <will.newton@imgtec.com>
---
 drivers/mmc/host/dw_mmc.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 58476c1..299c1d6 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1031,13 +1031,10 @@ static void dw_mci_read_data_pio(struct dw_mci *host)
 	struct mmc_data	*data = host->data;
 	int shift = host->data_shift;
 	u32 status;
-	unsigned int nbytes = 0, len, old_len, count = 0;
+	unsigned int nbytes = 0, len;
 
 	do {
 		len = SDMMC_GET_FCNT(mci_readl(host, STATUS)) << shift;
-		if (count == 0)
-			old_len = len;
-
 		if (offset + len <= sg->length) {
 			host->pull_data(host, (void *)(buf + offset), len);
 
@@ -1082,7 +1079,6 @@ static void dw_mci_read_data_pio(struct dw_mci *host)
 			tasklet_schedule(&host->tasklet);
 			return;
 		}
-		count++;
 	} while (status & SDMMC_INT_RXDR); /*if the RXDR is ready read again*/
 	len = SDMMC_GET_FCNT(mci_readl(host, STATUS));
 	host->pio_offset = offset;
-- 
1.7.0.1

Re: [PATCH] mmc: dw_mmc: Remove set-but-unused variable.

[Will Newton]

On Mon, Feb 28, 2011 at 9:55 PM, Chris Ball <cjb@laptop.org> wrote:
> count is only ever used by assigning to old_len if count == 0, and
> then old_len isn't ever used at all.  So, both are redundant.  Fixes:
>
> drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_read_data_pio’:
> drivers/mmc/host/dw_mmc.c:1034:32: warning: variable ‘old_len’ set but
> not used [-Wunused-but-set-variable]
>
> Signed-off-by: Chris Ball <cjb@laptop.org>
> Cc: Will Newton <will.newton@imgtec.com>

Looks good, thanks for fixing this!

Acked-by: Will Newton <will.newton@imgtec.com>

Re: [PATCH] mmc: dw_mmc: Remove set-but-unused variable.

[Jaehoon Chung]

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

Will Newton wrote:
> On Mon, Feb 28, 2011 at 9:55 PM, Chris Ball <cjb@laptop.org> wrote:
>> count is only ever used by assigning to old_len if count == 0, and
>> then old_len isn't ever used at all.  So, both are redundant.  Fixes:
>>
>> drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_read_data_pio’:
>> drivers/mmc/host/dw_mmc.c:1034:32: warning: variable ‘old_len’ set but
>> not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: Chris Ball <cjb@laptop.org>
>> Cc: Will Newton <will.newton@imgtec.com>
> 
> Looks good, thanks for fixing this!
> 
> Acked-by: Will Newton <will.newton@imgtec.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>