From: Jaehoon Chung <jh80.chung@samsung.com>
To: Will Newton <will.newton@gmail.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] dw_mmc: support send_auto_stop
Date: Thu, 31 Mar 2011 10:29:26 +0900 [thread overview]
Message-ID: <4D93D8F6.7000904@samsung.com> (raw)
In-Reply-To: <AANLkTikzkX7vYu0h7T6-C5PvykOZAzYGnTmPydizkTU6@mail.gmail.com>
Will Newton wrote:
> On Wed, Mar 30, 2011 at 6:55 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> This patch is set the send_auto_stop bit in CMD register.
>> If use DW_MCI_QUIRK_SEND_AUTO_STOP, helps to send an exact
>> number of data bytes.
>>
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> This is something I have been meaning to look into, does it improve
> latency or throughput in your experiments?
Not improve latency...but in my experiments,
when i used this, i could find the stable throughput..
>
> Is there a reason you have implemented it as a quirk? I would have
> thought if it was a win (in performance or code size) it would be
> applicable to all instances of this block?
I didn't test every case..so Somebody doesn't want to use send_auto_stop,
So i think good that used the quirks...
you can see Send_Auto_Stop generation table in DesigneWare MMC controller spec
I think that our case can use send_auto_stop...but i didn't ensure in other case
>
> If we implemented it as an unconditional feature then we could
> probably remove some of the explicit stop handling code.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2011-03-31 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 5:55 [PATCH] dw_mmc: support send_auto_stop Jaehoon Chung
2011-03-30 12:37 ` Will Newton
2011-03-31 1:29 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D93D8F6.7000904@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox