From: Jaehoon Chung <jh80.chung@samsung.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] mmc: sdhci: add error checking for mmc_add_host
Date: Mon, 04 Apr 2011 13:13:45 +0900 [thread overview]
Message-ID: <4D994579.10301@samsung.com> (raw)
In-Reply-To: <20110404034753.GA1428@pengutronix.de>
Wolfram Sang wrote:
> On Mon, Apr 04, 2011 at 11:48:57AM +0900, Jaehoon Chung wrote:
>> Sometimes we can't add the device,but we didn't check any error status.
>> Need to check error status for mmc_add_host.
>
> Thanks, this is correct, but...
>
>> - mmc_add_host(mmc);
>> + ret = mmc_add_host(mmc);
>> + if (unlikely(ret))
>> + goto err_free_mmc;
>
> ... you are leaking the irq and the lcd_classdev here.
Thanks for your comment, i will resend the patch.
>
> Regards,
>
> Wolfram
>
prev parent reply other threads:[~2011-04-04 4:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 2:48 [PATCH] mmc: sdhci: add error checking for mmc_add_host Jaehoon Chung
2011-04-04 3:47 ` Wolfram Sang
2011-04-04 4:13 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D994579.10301@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox