* [PATCH v3 2/2] mmc: sdhci: add regulator disable/put when control error
@ 2011-04-05 8:02 Jaehoon Chung
2011-04-08 18:38 ` Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Jaehoon Chung @ 2011-04-05 8:02 UTC (permalink / raw)
To: linux-mmc@vger.kernel.org; +Cc: Chris Ball, Wolfram Sang, Kyungmin Park
Missing regulator disable/put. Fixed them.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mmc/host/sdhci.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 1768ffb..35edcc1 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2048,6 +2048,10 @@ reset:
sdhci_reset(host, SDHCI_RESET_ALL);
free_irq(host->irq, host);
del_timer_sync(&host->timer);
+ if (host->vmmc) {
+ regulator_disable(host->vmmc);
+ regulator_put(host->vmmc);
+ }
untasklet:
tasklet_kill(&host->card_tasklet);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3 2/2] mmc: sdhci: add regulator disable/put when control error
2011-04-05 8:02 [PATCH v3 2/2] mmc: sdhci: add regulator disable/put when control error Jaehoon Chung
@ 2011-04-08 18:38 ` Wolfram Sang
2011-04-09 11:48 ` Jae hoon Chung
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2011-04-08 18:38 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc@vger.kernel.org, Chris Ball, Kyungmin Park
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On Tue, Apr 05, 2011 at 05:02:20PM +0900, Jaehoon Chung wrote:
> Missing regulator disable/put. Fixed them.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Looks OK but could be merged into the previous patch.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/2] mmc: sdhci: add regulator disable/put when control error
2011-04-08 18:38 ` Wolfram Sang
@ 2011-04-09 11:48 ` Jae hoon Chung
2011-04-09 15:53 ` Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Jae hoon Chung @ 2011-04-09 11:48 UTC (permalink / raw)
To: Wolfram Sang
Cc: Jaehoon Chung, linux-mmc@vger.kernel.org, Chris Ball,
Kyungmin Park
Hi..
2011/4/9 Wolfram Sang <w.sang@pengutronix.de>:
> On Tue, Apr 05, 2011 at 05:02:20PM +0900, Jaehoon Chung wrote:
>> Missing regulator disable/put. Fixed them.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> Looks OK but could be merged into the previous patch.
Thanks. :)
yes, i can be merged into the previous patch.
But i think good that separeted. anyway..don't mind merged or not?
Regards,
Jaehoon Chung
>
> --
> Pengutronix e.K. | Wolfram Sang |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAk2fViEACgkQD27XaX1/VRt1+wCaAxSjsZ+GqVdhnca16rMsO7LK
> jfcAnjvIvSBSFknx7nMomkT6I4Y1YTgV
> =KfuE
> -----END PGP SIGNATURE-----
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-04-09 15:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-05 8:02 [PATCH v3 2/2] mmc: sdhci: add regulator disable/put when control error Jaehoon Chung
2011-04-08 18:38 ` Wolfram Sang
2011-04-09 11:48 ` Jae hoon Chung
2011-04-09 15:53 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).