linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Potential Bug in drivers/mmc/
@ 2011-04-09  1:34 Prashanth Bhat
  0 siblings, 0 replies; only message in thread
From: Prashanth Bhat @ 2011-04-09  1:34 UTC (permalink / raw)
  To: mirq-linux, adrian.hunter, cjb, linux-mmc, akpm, torvalds

Hi,

I'm new to Linux kernel code, but I think I spot a bug in a commit made 
to drivers/mmc/core/bus.c in 2.6.36, back in Aug 2010.

Here's the GIT URL showing the changes in this commit:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7310ece86ad7da027f85a37a0638164118a5d12f

At line 239, the following code change was made:

+ case MMC_TYPE_SD_COMBO:
+               type = "SD-combo";
+               if (mmc_card_blockaddr(card))
+                       type = "SDHC-combo";


The bug : I would have expected to see a "break" at the end of the new 
case entry. I don't see this, even in a later version of the source 
(namely 2.6.38).

Please take a look, and also let me know what you decide.

Thanks,
Prashanth Bhat

=============================================================
Prashanth B. Bhat,  Ph. D.
Chief Technology Officer,
Manipal Dot Net Pvt. Ltd.
Manipal 576 104 INDIA

http://www.linkedin.com/in/prashanthbhat
http://www.manipal.net
prashanth.bhat@manipal.net
=============================================================

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-04-09  1:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-09  1:34 Potential Bug in drivers/mmc/ Prashanth Bhat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).