From: David Vrabel <david.vrabel@csr.com>
To: Per Forlin <per.forlin@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH v2 01/12] mmc: add none blocking mmc request function
Date: Fri, 15 Apr 2011 11:34:42 +0100 [thread overview]
Message-ID: <4DA81F42.3070208@csr.com> (raw)
In-Reply-To: <1302116833-24540-2-git-send-email-per.forlin@linaro.org>
On 06/04/11 20:07, Per Forlin wrote:
> Previously there has only been one function mmc_wait_for_req
> to start and wait for a request. This patch adds
> * mmc_start_req - starts a request wihtout waiting
> * mmc_wait_for_req_done - waits until request is done
> * mmc_pre_req - asks the host driver to prepare for the next job
> * mmc_post_req - asks the host driver to clean up after a completed job
If MMC core had a queue of requests internally you wouldn't need to
provide mmc_pre_req() and mmc_post_req() functions outside of the core.
i.e., the mmc block driver would just need to queue up two mmc requests
and the core would take care of calling pre_req and post_req at the
correct time.
Using a MMC request queue has other benefits -- it allows multiple users
without having to claim/release the host. This would be useful for
(especially multi-function) SDIO.
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
next prev parent reply other threads:[~2011-04-15 10:35 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 19:07 [PATCH v2 00/12] mmc: use nonblock mmc requests to minimize latency Per Forlin
2011-04-06 19:07 ` [PATCH v2 01/12] mmc: add none blocking mmc request function Per Forlin
2011-04-15 10:34 ` David Vrabel [this message]
2011-04-20 7:17 ` Per Forlin
2011-04-26 13:29 ` David Vrabel
[not found] ` <4DB6C89F.10903-kQvG35nSl+M@public.gmane.org>
2011-04-26 14:22 ` Per Forlin
[not found] ` <1302116833-24540-1-git-send-email-per.forlin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-04-06 19:07 ` [PATCH v2 02/12] mmc: mmc_test: add debugfs file to list all tests Per Forlin
2011-04-06 19:07 ` [PATCH v2 03/12] mmc: mmc_test: add test for none blocking transfers Per Forlin
2011-04-17 7:09 ` Lin Tony-B19295
2011-04-20 7:30 ` Per Forlin
[not found] ` <1302116833-24540-4-git-send-email-per.forlin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-04-17 15:46 ` Shawn Guo
2011-04-20 7:41 ` Per Forlin
2011-04-06 19:07 ` [PATCH v2 04/12] mmc: add member in mmc queue struct to hold request data Per Forlin
2011-04-06 19:07 ` [PATCH v2 05/12] mmc: add a block request prepare function Per Forlin
2011-04-06 19:07 ` [PATCH v2 06/12] mmc: move error code in mmc_block_issue_rw_rq to a separate function Per Forlin
2011-04-06 19:07 ` [PATCH v2 07/12] mmc: add a second mmc queue request member Per Forlin
2011-04-06 19:07 ` [PATCH v2 08/12] mmc: add handling for two parallel block requests in issue_rw_rq Per Forlin
2011-04-20 11:32 ` Per Forlin
2011-04-06 19:07 ` [PATCH v2 09/12] mmc: test: add random fault injection in core.c Per Forlin
2011-04-06 19:07 ` [PATCH v2 10/12] omap_hsmmc: use original sg_len for dma_unmap_sg Per Forlin
2011-04-06 19:07 ` [PATCH v2 11/12] omap_hsmmc: add support for pre_req and post_req Per Forlin
2011-04-06 19:07 ` [PATCH v2 12/12] mmci: implement pre_req() and post_req() Per Forlin
2011-04-08 16:49 ` [PATCH v2 00/12] mmc: use nonblock mmc requests to minimize latency Linus Walleij
2011-04-09 11:55 ` Jae hoon Chung
[not found] ` <BANLkTikVeXvfSBS-xLDXVdesKJpKdtUVqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-10 3:33 ` anish singh
2011-04-11 9:03 ` Per Forlin
[not found] ` <BANLkTikoj6UTx08ntZaMM15taKRXjrU_Mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-11 9:07 ` Sachin Nikam
2011-04-11 9:08 ` Per Forlin
2011-04-19 14:30 ` Jae hoon Chung
2011-04-16 15:48 ` Shawn Guo
2011-04-20 8:19 ` Per Forlin
2011-04-16 16:48 ` [PATCH] mmc: sdhci: add support for pre_req and post_req Shawn Guo
2011-04-16 23:06 ` Andrei Warkentin
2011-04-22 11:01 ` Jaehoon Chung
2011-04-27 0:59 ` Andrei Warkentin
2011-04-26 1:26 ` Jaehoon Chung
2011-04-26 2:47 ` Shawn Guo
2011-04-26 10:21 ` Per Forlin
2011-04-17 16:33 ` [PATCH] mmc: mxs-mmc: " Shawn Guo
2011-04-17 16:48 ` Shawn Guo
2011-04-20 8:01 ` Per Forlin
2011-04-20 14:01 ` Shawn Guo
2011-04-20 15:22 ` Per Forlin
2011-04-21 6:25 ` Shawn Guo
2011-04-21 8:52 ` Per Forlin
2011-04-20 15:30 ` Per Forlin
2011-04-21 6:29 ` Shawn Guo
2011-04-21 8:46 ` Per Forlin
2011-04-21 9:11 ` Shawn Guo
2011-04-21 9:47 ` Per Forlin
2011-04-21 10:15 ` Per Forlin
2011-04-28 7:52 ` Per Forlin
2011-04-28 10:10 ` Russell King - ARM Linux
2011-04-20 7:58 ` Per Forlin
2011-04-20 8:17 ` Shawn Guo
2011-04-20 13:51 ` [PATCH v2] " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA81F42.3070208@csr.com \
--to=david.vrabel@csr.com \
--cc=cjb@laptop.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=per.forlin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).