From: Lars-Peter Clausen <lars@metafoo.de>
To: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org, Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH] mmc: sdhci: Conditionalize regulator_get() on CONFIG_REGULATOR
Date: Sat, 30 Apr 2011 17:06:46 +0200 [thread overview]
Message-ID: <4DBC2586.1080201@metafoo.de> (raw)
In-Reply-To: <m3r58k1hlc.fsf@pullcord.laptop.org>
On 04/30/2011 06:35 AM, Chris Ball wrote:
> The regulator subsystem provides stubbed out versions of its calls that
> are always present (so that they can be used without needing #ifdefs).
> But the regulator_get() stub always returns an error value according
> to IS_ERR(), which leads sdhci to print messages like "mmc0: no vmmc
> regulator found" on every boot, even if CONFIG_REGULATOR is not set.
>
> This patch fixes that (and removes the unwanted message) by having
> the regulator_get() call occur inside an #ifdef CONFIG_REGULATOR.
Shouldn't the stubbed version of regulator_get return NULL, which is not
treated as an error by IS_ERR?
- Lars
next prev parent reply other threads:[~2011-04-30 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-30 4:35 [PATCH] mmc: sdhci: Conditionalize regulator_get() on CONFIG_REGULATOR Chris Ball
2011-04-30 15:06 ` Lars-Peter Clausen [this message]
2011-04-30 16:03 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBC2586.1080201@metafoo.de \
--to=lars@metafoo.de \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox