From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 07/22] mmc: omap_hsmmc: fix missing mmc_release_host() in no_off case Date: Thu, 05 May 2011 17:08:59 +0400 Message-ID: <4DC2A16B.8050209@ru.mvista.com> References: <1304596282-4095-1-git-send-email-adrian.hunter@nokia.com> <1304596282-4095-8-git-send-email-adrian.hunter@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1304596282-4095-8-git-send-email-adrian.hunter@nokia.com> Sender: linux-omap-owner@vger.kernel.org To: Adrian Hunter Cc: Tony Lindgren , linux-mmc Mailing List , Sudhir Bera , Madhusudhan Chikkature , linux-omap Mailing List , linux-arm Mailing List List-Id: linux-mmc@vger.kernel.org Hello. On 05-05-2011 15:51, Adrian Hunter wrote: > From: Sudhir Bera > In fact the no_off check here will not be hit because > 'omap_hsmmc_disabled_to_sleep()' won't schedule a > deeper disable in the no_off case. > Signed-off-by: Sudhir Bera > Signed-off-by: Adrian Hunter > --- > drivers/mmc/host/omap_hsmmc.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index bab25ff..bd52849 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1852,14 +1852,13 @@ static int omap_hsmmc_sleep_to_off(struct omap_hsmmc_host *host) > return 0; > > if (mmc_slot(host).no_off) > - return 0; > + goto out; > > if (!((host->mmc->caps& MMC_CAP_NONREMOVABLE) || > mmc_slot(host).card_detect || > (mmc_slot(host).get_cover_state && > mmc_slot(host).get_cover_state(host->dev, host->slot_id)))) { > - mmc_release_host(host->mmc); > - return 0; > + goto out; > } This has become a single statement, so {} shpould be removed, no? checkpatch.pl probably warns here?.. WBR, Sergei