From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Motyka Subject: Re: [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' Date: Mon, 09 May 2011 18:08:28 +0200 Message-ID: <4DC8117C.7060200@gmail.com> References: <4DC7F4AB.90607@gmail.com> <4DC802C0.9040302@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:36362 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752827Ab1EIQJQ (ORCPT ); Mon, 9 May 2011 12:09:16 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: cjb@laptop.org Cc: Julia Lawall , kernel-janitors@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org When allocation of idata fails there was a null dereference. Signed-off-by: Vladimir Motyka --- diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 407836d..a03cdc6 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -237,7 +237,7 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user( idata = kzalloc(sizeof(*idata), GFP_KERNEL); if (!idata) { err = -ENOMEM; - goto copy_err; + goto alloc_err; } if (copy_from_user(&idata->ic, user, sizeof(idata->ic))) { @@ -268,8 +268,8 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user( copy_err: kfree(idata->buf); kfree(idata); +alloc_err: return ERR_PTR(err); - } static int mmc_blk_ioctl_cmd(struct block_device *bdev,