From: Jaehoon Chung <jh80.chung@samsung.com>
To: Chris Ball <cjb@laptop.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
will.newton@imgtec.com, Kyungmin Park <kyungmin.park@samsung.com>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH] dw_mmc: fixed regulator control
Date: Wed, 11 May 2011 12:00:33 +0900 [thread overview]
Message-ID: <4DC9FBD1.2000803@samsung.com> (raw)
In-Reply-To: <m3boza6neb.fsf@pullcord.laptop.org>
Chris Ball wrote:
> Hi Jaehoon,
>
> On Mon, May 02 2011, Jaehoon Chung wrote:
>> Hi Chris..
>>
>> Thanks for comments...
>> I think that could confuse that message when didn't set CONFIG_REGULATOR.
>
> The message *does not appear* when CONFIG_REGULATOR is unset, because
> NULL -- which the regulator subsystem returns via the regulator_get()
> stub -- is not an IS_ERR(). Do you agree?
Thanks, I agreed that.
I'm interesting mailing's discussion about "[PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR "
(in this case, i think similar case)
>
>> And i wonder how do you think about regulator control in suspend (dw_mmc.c)?
>
> Yes, that patch looks correct, although I can't test it myself. Please
> send it separately.
Ok. i will send that separately patch.
Regards,
Jaehoon Chung
prev parent reply other threads:[~2011-05-11 3:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 10:19 [PATCH] dw_mmc: fixed regulator control Jaehoon Chung
2011-04-30 16:09 ` Chris Ball
2011-05-02 7:53 ` Jaehoon Chung
2011-05-11 1:23 ` Chris Ball
2011-05-11 3:00 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC9FBD1.2000803@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).