From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Subject: Re: [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c Date: Fri, 29 Jul 2011 11:17:11 +0900 Message-ID: <4E321827.5020606@samsung.com> References: <1311851023-3563-1-git-send-email-shashidharh@vayavyalabs.com> <4E314562.2000001@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:35653 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754308Ab1G2CR0 (ORCPT ); Thu, 28 Jul 2011 22:17:26 -0400 In-reply-to: <4E314562.2000001@imgtec.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: James Hogan Cc: Shashidhar Hiremath , Will Newton , Kyungmin Park , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Hi.. this patch is right. Acked-by : Jaehoon Chung Regards, Jaehoon Chung James Hogan wrote: > On 07/28/2011 12:03 PM, Shashidhar Hiremath wrote: >> The mask used inside this macro was assuming Buffer_Size1's[BS1's] width to be 14 bits, >> it is actually of 13 bits, Modified masks used in IDMAC_SET_BUFFER1_SIZE such that >> they use only 13 bits instead of current 14. >> >> Signed-off-by: Shashidhar Hiremath >> --- >> drivers/mmc/host/dw_mmc.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 77f0b6b..f13bb49 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -62,7 +62,7 @@ struct idmac_desc { >> >> u32 des1; /* Buffer sizes */ >> #define IDMAC_SET_BUFFER1_SIZE(d, s) \ >> - ((d)->des1 = ((d)->des1 & 0x03ffc000) | ((s) & 0x3fff)) >> + ((d)->des1 = ((d)->des1 & 0x03ffe000) | ((s) & 0x1fff)) >> >> u32 des2; /* buffer 1 physical address */ >> > > Yes, according to the TRM you appear to be correct > > Reviewed-by: James Hogan > > Thanks > James > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >