public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Shashidhar Hiremath <shashidharh@vayavyalabs.com>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	Will <will.newton@imgtec.com>
Subject: Re: A few queries dw_mmc driver
Date: Thu, 04 Aug 2011 11:20:32 +0100	[thread overview]
Message-ID: <4E3A7270.8030304@imgtec.com> (raw)
In-Reply-To: <4E38708D.9070801@imgtec.com>

Hi Shashidhar

On 08/02/2011 10:47 PM, James Hogan wrote:
>>   I was adding the support for Dual_Buffer Descriptors support in dw_mmc
>> driver.Does it require a change in the above elements of mmc_host
>> structure ?
> 
> I don't know, but I'll see if I can find out.

The initial IDMAC settings were relatively sane defaults taken from the
original NXP driver, and things that were deducted from the source. Most
of the values pertain to the block layer:

* max_seg_size   /* upper limit on size of a coalesced segment */
* max_segs       /* upper limit on hw data segments in a request */
* max_req_size   /* maximum number of bytes in one request */
* max_blk_size   /* maximum size of one mmc block */
* max_blk_count  /* maximum number of blocks in one request */

They may not be the most efficient defaults, as they used the whole of
the IDMAC bandwidth (max_segs and max_blk_count are the size of the
whole ring buffer, and max_seg_size is the size of the largest DMA
transferrable block) but this shouldn't hinder a dual-buffered
implementation.

Cheers
James


      reply	other threads:[~2011-08-04 10:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CANYdXnrvEJiehbz53WHMriAqn8F0uhnCFEE=x0gy19hfTXZStw@mail.gmail.com>
     [not found] ` <CANYdXnpG2oyXL2wVzdE=h4S1SHR_tsvoBwU4VVDQmTjtU0fL5g@mail.gmail.com>
     [not found]   ` <CANYdXnrYaqck5ekWtjcP+HDmRcav3kxew6dVuv5jgemURR3uZw@mail.gmail.com>
2011-08-02 21:47     ` A few queries dw_mmc driver James Hogan
2011-08-04 10:20       ` James Hogan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E3A7270.8030304@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=shashidharh@vayavyalabs.com \
    --cc=will.newton@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox