public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: J Freyensee <james_p_freyensee@linux.intel.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Chris Ball <cjb@laptop.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Chuanxiao Dong <chuanxiao.dong@intel.com>,
	Hanumath Prasad <hanumath.prasad@stericsson.com>
Subject: Re: [RFC PATCH] mmc: support background operation
Date: Wed, 17 Aug 2011 20:16:06 -0700	[thread overview]
Message-ID: <4E4C83F6.6080608@linux.intel.com> (raw)
In-Reply-To: <4E4C74EB.8050702@samsung.com>

On 08/17/2011 07:11 PM, Jaehoon Chung wrote:
> Hi Jay..
>
> I didn't know the tool 'sparse'. i will check the tool for your advice.
> Thank you a lot for your help.. :)

here, I'll provide it from a write-up I did within my department. 
Unfortunately, finding documentation how to use it is pretty hard 
because very little is provided.

-------------------------------------------------
Step 9 in SubmitChecklist documentation in preparing to submit a device 
driver upstream to Linus's kernel is:

9: Check cleanly with sparse.

Sparse is a tool written by Linus that contains built-in checks
for known problematic and a set of annotations in the Linux kernel
designed to convey semantic information about types, such as what
address space pointers point to, or what locks a function acquires or
releases.  It does appear to be a useful tool to make your code that
much more tight.

The #1 problem with this tool is there is little documentation how to 
use it.  I think I figured it out how to use it, basic-wise,
with the help of searching on-line forums.

To set up and use for the first time:
1. git clone git://git.kernel.org/pub/scm/devel/sparse/sparse.git
2. cd to the sparse directory
3. make; sudo make install
4. cd to your linux kernel
5. 'make C=1 >& sparse.log' if you have not built your kernel,
OR
'make C=2 >& sparse.log' if you have already built your kernel

I HIGHLY recommend the file redirection operator because a LOT OF STUFF
GETS SPIT OUT.

6. To use other macros, do something like:

make C=1 CF=
example:
make C=2 CF="-D__CHECK_ENDIAN__" (to check endianess)

Further info:
http://en.wikipedia.org/wiki/Sparse
-------------------------------------------------

>
>> Unfortunately, I am still a little new to this area of the Linux kernel
>> so I don't quite have the background to give an intelligent answer
>> w/respect to eMMC 4.41 and BKOPS.  I just have 3 device driver accepts
>> in the TTY space, so my contributions to patches are mainly basic code
>> functionality and Linux kernel/device-driver gotchas.
>>
>> Do you know the tool 'sparse'?  It's a good thing to try once, before
>> submitting upstream, if you haven't done it.
>>
>>>
>>> Regards,
>>> Jaehoon Chung
>>>
>>>
>>>
>>
>>
>


-- 
J (James/Jay) Freyensee
Storage Technology Group
Intel Corporation

  reply	other threads:[~2011-08-18  3:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 11:14 [RFC PATCH] mmc: support background operation Jaehoon Chung
2011-08-16 16:35 ` J Freyensee
2011-08-16 16:43   ` Chris Ball
2011-08-17  4:03   ` Jaehoon Chung
2011-08-17 16:13     ` J Freyensee
2011-08-18  2:11       ` Jaehoon Chung
2011-08-18  3:16         ` J Freyensee [this message]
2011-08-17  8:02 ` Seungwon Jeon
2011-08-17  8:13   ` Jaehoon Chung
2011-08-17  8:30     ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4C83F6.6080608@linux.intel.com \
    --to=james_p_freyensee@linux.intel.com \
    --cc=chuanxiao.dong@intel.com \
    --cc=cjb@laptop.org \
    --cc=hanumath.prasad@stericsson.com \
    --cc=jh80.chung@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox