From: Ulf Hansson <ulf.hansson@stericsson.com>
To: Sujit Reddy Thumma <sthumma@codeaurora.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Per FORLIN <per.forlin@stericsson.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] mmc: core: Prevent too long response times for suspend
Date: Mon, 17 Oct 2011 11:51:00 +0200 [thread overview]
Message-ID: <4E9BFA84.1040709@stericsson.com> (raw)
In-Reply-To: <4f62290baad48cd8655f3f82f7b162b9.squirrel@www.codeaurora.org>
>
> Why would there be pending requests while host is suspending? Is the
> kernel framework not handling sync before going to suspend? However, the
> mmc_blk_suspend() would be called before the host driver suspends (as all
> the driver suspend routines are serialized) which means it stops block
> layer to queue more I/O requests well before the host driver start
> suspend. Does this sequence break in your case?
I have observed this issue for different cases (one case was logging to
eMMC). The idea is simply that we would like to be sure that we do not
wait "forever", no matter if the "upper layers" misbehaved in the
suspend sequence.
>
> Your concern seems to be valid for SDIO case, but again the function
> driver must be intelligent enough to return -EBUSY as it knows that it had
> posted a request to MMC.
>
For SDIO, should we really assume that function driver has implemented a
suspend function and moreover that it actually always behaves as we expect?
Br
Ulf Hansson
next prev parent reply other threads:[~2011-10-17 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 14:03 [PATCH] mmc: core: Prevent too long response times for suspend Ulf Hansson
2011-10-15 6:47 ` Sujit Reddy Thumma
2011-10-17 9:51 ` Ulf Hansson [this message]
2011-10-19 17:25 ` Sujit Reddy Thumma
2011-10-19 22:09 ` Linus Walleij
2011-10-21 4:25 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9BFA84.1040709@stericsson.com \
--to=ulf.hansson@stericsson.com \
--cc=cjb@laptop.org \
--cc=lee.jones@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=per.forlin@stericsson.com \
--cc=sthumma@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox