* [PATCH] mmc: core: fix the critical bug for multiple block read
@ 2011-10-31 10:46 Jaehoon Chung
2011-10-31 10:52 ` Jaehoon Chung
2011-11-01 9:49 ` Chris Ball
0 siblings, 2 replies; 3+ messages in thread
From: Jaehoon Chung @ 2011-10-31 10:46 UTC (permalink / raw)
To: linux-mmc; +Cc: Chris Ball, Kyungmin Park, paul
This patch is fixed the critical bug for multiple block read.
In Paul's patch(commit:6d621423128909f09072835445ce36dd357a758a),
used MMC_CAP2_NO_MULTI_READ. But that value was assigned host->mmc->caps.
MMC_CAPS2_NO_MULTI_READ must assign host->mmc->caps2 instead of host->mmc->caps.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mmc/card/block.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 4fd5723..1882149 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -1037,7 +1037,7 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,
brq->data.blocks = 1;
/* Some controllers can't do multiblock reads due to hw bugs */
- if (card->host->caps & MMC_CAP2_NO_MULTI_READ &&
+ if (card->host->caps2 & MMC_CAP2_NO_MULTI_READ &&
rq_data_dir(req) == READ)
brq->data.blocks = 1;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: core: fix the critical bug for multiple block read
2011-10-31 10:46 [PATCH] mmc: core: fix the critical bug for multiple block read Jaehoon Chung
@ 2011-10-31 10:52 ` Jaehoon Chung
2011-11-01 9:49 ` Chris Ball
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2011-10-31 10:52 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc, Chris Ball, Kyungmin Park, paul
Sorry card->host->caps instead of host->mmc->caps.(typo)
On 10/31/2011 07:46 PM, Jaehoon Chung wrote:
> This patch is fixed the critical bug for multiple block read.
>
> In Paul's patch(commit:6d621423128909f09072835445ce36dd357a758a),
> used MMC_CAP2_NO_MULTI_READ. But that value was assigned card->host->caps.
>
> MMC_CAPS2_NO_MULTI_READ must assign card->host->caps2 instead of card->host->caps.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/card/block.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 4fd5723..1882149 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -1037,7 +1037,7 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,
> brq->data.blocks = 1;
>
> /* Some controllers can't do multiblock reads due to hw bugs */
> - if (card->host->caps & MMC_CAP2_NO_MULTI_READ &&
> + if (card->host->caps2 & MMC_CAP2_NO_MULTI_READ &&
> rq_data_dir(req) == READ)
> brq->data.blocks = 1;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: core: fix the critical bug for multiple block read
2011-10-31 10:46 [PATCH] mmc: core: fix the critical bug for multiple block read Jaehoon Chung
2011-10-31 10:52 ` Jaehoon Chung
@ 2011-11-01 9:49 ` Chris Ball
1 sibling, 0 replies; 3+ messages in thread
From: Chris Ball @ 2011-11-01 9:49 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc, Kyungmin Park, paul
Hi,
On Mon, Oct 31 2011, Jaehoon Chung wrote:
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 4fd5723..1882149 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -1037,7 +1037,7 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,
> brq->data.blocks = 1;
>
> /* Some controllers can't do multiblock reads due to hw bugs */
> - if (card->host->caps & MMC_CAP2_NO_MULTI_READ &&
> + if (card->host->caps2 & MMC_CAP2_NO_MULTI_READ &&
> rq_data_dir(req) == READ)
> brq->data.blocks = 1;
> }
>
Already fixed in mmc-next, with a rebase. Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-01 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-31 10:46 [PATCH] mmc: core: fix the critical bug for multiple block read Jaehoon Chung
2011-10-31 10:52 ` Jaehoon Chung
2011-11-01 9:49 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox