From: Adrian Hunter <adrian.hunter@intel.com>
To: joe@perches.com
Cc: linux-kernel@vger.kernel.org, linux-mmc <linux-mmc@vger.kernel.org>
Subject: Incorrect checkpatch warning
Date: Fri, 04 Nov 2011 10:00:52 +0200 [thread overview]
Message-ID: <4EB39BB4.3060508@intel.com> (raw)
Hi
This checkpatch warning looks wrong:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#73: FILE: drivers/mmc/host/sdhci-pci-data.c:5:
+EXPORT_SYMBOL_GPL(sdhci_pci_get_data);
The patch has this:
diff --git a/drivers/mmc/host/sdhci-pci-data.c b/drivers/mmc/host/sdhci-pci-data.c
new file mode 100644
index 0000000..a611217
--- /dev/null
+++ b/drivers/mmc/host/sdhci-pci-data.c
@@ -0,0 +1,5 @@
+#include <linux/module.h>
+#include <linux/mmc/sdhci-pci-data.h>
+
+struct sdhci_pci_data *(*sdhci_pci_get_data)(struct pci_dev *pdev, int slotno);
+EXPORT_SYMBOL_GPL(sdhci_pci_get_data);
Regards
Adrian
next reply other threads:[~2011-11-04 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 8:00 Adrian Hunter [this message]
2011-11-04 10:23 ` Incorrect checkpatch warning Girish K S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB39BB4.3060508@intel.com \
--to=adrian.hunter@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox