* [PATCH] mmc: core: Fix setting power notify state variable for non eMMC
@ 2011-11-04 10:52 Girish K S
2011-11-04 11:29 ` Girish K S
2011-11-11 13:32 ` Ulf Hansson
0 siblings, 2 replies; 4+ messages in thread
From: Girish K S @ 2011-11-04 10:52 UTC (permalink / raw)
To: linux-mmc; +Cc: cjb, patches, linux-samsung-soc, Girish K S
This patch skips the setting of the power notify state variable
for non eMMC 4.5 devices. Also fixes the problem of omap_hsmmc
noisy/broken for suspend resume reported by kevin Hilman.
cc: Chris Ball <cjb@laptop.org>
Signed-off-by: Girish K S <girish.shivananjappa@linaro.org>
---
drivers/mmc/core/mmc.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 3627044..4db73a9 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -882,10 +882,14 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
card->ext_csd.generic_cmd6_time);
if (err && err != -EBADMSG)
goto free_card;
- }
- if (!err)
- card->poweroff_notify_state = MMC_POWERED_ON;
+ /*
+ * The err can be -EBADMSG or 0,
+ * so check for success and update the flag
+ */
+ if (!err)
+ card->poweroff_notify_state = MMC_POWERED_ON;
+ }
/*
* Activate high speed (if supported)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: core: Fix setting power notify state variable for non eMMC
2011-11-04 10:52 [PATCH] mmc: core: Fix setting power notify state variable for non eMMC Girish K S
@ 2011-11-04 11:29 ` Girish K S
2011-11-11 13:32 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Girish K S @ 2011-11-04 11:29 UTC (permalink / raw)
To: linux-mmc; +Cc: cjb, patches, linux-samsung-soc, Girish K S
On 4 November 2011 06:52, Girish K S <girish.shivananjappa@linaro.org> wrote:
> This patch skips the setting of the power notify state variable
> for non eMMC 4.5 devices. Also fixes the problem of omap_hsmmc
> noisy/broken for suspend resume reported by kevin Hilman.
>
> cc: Chris Ball <cjb@laptop.org>
> Signed-off-by: Girish K S <girish.shivananjappa@linaro.org>
> ---
> drivers/mmc/core/mmc.c | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 3627044..4db73a9 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -882,10 +882,14 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> card->ext_csd.generic_cmd6_time);
> if (err && err != -EBADMSG)
> goto free_card;
> - }
>
> - if (!err)
> - card->poweroff_notify_state = MMC_POWERED_ON;
> + /*
> + * The err can be -EBADMSG or 0,
> + * so check for success and update the flag
> + */
> + if (!err)
> + card->poweroff_notify_state = MMC_POWERED_ON;
> + }
>
> /*
> * Activate high speed (if supported)
> --
> 1.7.4.1
>
>Hi Chris,
this patch is based on for-linus branch.
Regards
Girish K S
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: core: Fix setting power notify state variable for non eMMC
2011-11-04 10:52 [PATCH] mmc: core: Fix setting power notify state variable for non eMMC Girish K S
2011-11-04 11:29 ` Girish K S
@ 2011-11-11 13:32 ` Ulf Hansson
2011-11-12 3:12 ` Chris Ball
1 sibling, 1 reply; 4+ messages in thread
From: Ulf Hansson @ 2011-11-11 13:32 UTC (permalink / raw)
To: Girish K S
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org, patches@linaro.org,
linux-samsung-soc@vger.kernel.org
Girish K S wrote:
> This patch skips the setting of the power notify state variable
> for non eMMC 4.5 devices. Also fixes the problem of omap_hsmmc
> noisy/broken for suspend resume reported by kevin Hilman.
>
> cc: Chris Ball <cjb@laptop.org>
> Signed-off-by: Girish K S <girish.shivananjappa@linaro.org>
> ---
> drivers/mmc/core/mmc.c | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 3627044..4db73a9 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -882,10 +882,14 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> card->ext_csd.generic_cmd6_time);
> if (err && err != -EBADMSG)
> goto free_card;
> - }
>
> - if (!err)
> - card->poweroff_notify_state = MMC_POWERED_ON;
> + /*
> + * The err can be -EBADMSG or 0,
> + * so check for success and update the flag
> + */
> + if (!err)
> + card->poweroff_notify_state = MMC_POWERED_ON;
> + }
>
> /*
> * Activate high speed (if supported)
I encountered similar problems as for omap_hsmmc for the mmci driver
(although with some ST-Ericsson internal pm_runtime patches). This patch
fixed the problem. Great!
Acked-by: Ulf Hansson <ulf.hansson@stericsson.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: core: Fix setting power notify state variable for non eMMC
2011-11-11 13:32 ` Ulf Hansson
@ 2011-11-12 3:12 ` Chris Ball
0 siblings, 0 replies; 4+ messages in thread
From: Chris Ball @ 2011-11-12 3:12 UTC (permalink / raw)
To: Ulf Hansson
Cc: Girish K S, linux-mmc@vger.kernel.org, patches@linaro.org,
linux-samsung-soc@vger.kernel.org
Hi,
On Fri, Nov 11 2011, Ulf Hansson wrote:
> Girish K S wrote:
>> This patch skips the setting of the power notify state variable
>> for non eMMC 4.5 devices. Also fixes the problem of omap_hsmmc
>> noisy/broken for suspend resume reported by kevin Hilman.
>>
>> cc: Chris Ball <cjb@laptop.org>
>> Signed-off-by: Girish K S <girish.shivananjappa@linaro.org>
>> ---
>> drivers/mmc/core/mmc.c | 10 +++++++---
>> 1 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
>> index 3627044..4db73a9 100644
>> --- a/drivers/mmc/core/mmc.c
>> +++ b/drivers/mmc/core/mmc.c
>> @@ -882,10 +882,14 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
>> card->ext_csd.generic_cmd6_time);
>> if (err && err != -EBADMSG)
>> goto free_card;
>> - }
>> - if (!err)
>> - card->poweroff_notify_state = MMC_POWERED_ON;
>> + /*
>> + * The err can be -EBADMSG or 0,
>> + * so check for success and update the flag
>> + */
>> + if (!err)
>> + card->poweroff_notify_state = MMC_POWERED_ON;
>> + }
>> /*
>> * Activate high speed (if supported)
>
>
> I encountered similar problems as for omap_hsmmc for the mmci driver
> (although with some ST-Ericsson internal pm_runtime patches). This
> patch fixed the problem. Great!
>
> Acked-by: Ulf Hansson <ulf.hansson@stericsson.com>
Thanks, pushed to mmc-next for 3.2.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-12 3:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-04 10:52 [PATCH] mmc: core: Fix setting power notify state variable for non eMMC Girish K S
2011-11-04 11:29 ` Girish K S
2011-11-11 13:32 ` Ulf Hansson
2011-11-12 3:12 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox