From: James Hogan <james.hogan@imgtec.com>
To: Shashidhar Hiremath <shashidharh@vayavyalabs.com>
Cc: Chris Ball <cjb@laptop.org>, Shawn Guo <shawn.guo@linaro.org>,
Philip Rakity <prakity@marvell.com>,
"Mark F. Brown" <mark.brown314@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Will Newton <will.newton@imgtec.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/1] mmc:Support of PCI mode for the dw_mmc driver
Date: Wed, 30 Nov 2011 15:41:31 +0000 [thread overview]
Message-ID: <4ED64EAB.4050405@imgtec.com> (raw)
In-Reply-To: <CANYdXnr1+gNmE0nTf0BOHMFZnwsJgYKk8ZcAJqdutDTx25gnWQ@mail.gmail.com>
Hi,
On 11/30/2011 03:27 PM, Shashidhar Hiremath wrote:
> Hi James,
> Sorry for the minor alignment issues.Will fix them .
Thanks
> I actually did
> compile the code but as separate driver not along with the kernel. In
> fact, I have also tested the PCI patch ,but not as separate files but
> with the earlier #ifdef method I had sent in initial patch .
But the new patch was completely different, you can't just rework the
entire patch and expect it to compile and work without at least trying
it to make sure, as evidenced by the fact that with mmc_next + your
patch, I get:
dw_mmc.c: 7 errors, 22 warnings
dw_mmc-pci.c: 2 errors
dw_mmc-pltfm.c: 6 errors, 1 warning
Cheers
James
> On Wed, Nov 30, 2011 at 7:36 PM, James Hogan <james.hogan@imgtec.com> wrote:
>> *sigh* You haven't actually tried compiling this have you? How do you
>> know whether it works or not? You really really should at least make
>> sure it compiles (for simple changes) and works without breaking
>> anything (for anything non-trivial like adding support for a new bus
>> like PCI)!
next prev parent reply other threads:[~2011-11-30 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 12:36 [PATCH 1/1] mmc:Support of PCI mode for the dw_mmc driver Shashidhar Hiremath
2011-11-30 14:06 ` James Hogan
2011-11-30 15:27 ` Shashidhar Hiremath
2011-11-30 15:41 ` James Hogan [this message]
2011-11-30 16:01 ` Shashidhar Hiremath
2011-11-30 18:20 ` Shashidhar Hiremath
2011-11-30 21:49 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED64EAB.4050405@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.brown314@gmail.com \
--cc=prakity@marvell.com \
--cc=shashidharh@vayavyalabs.com \
--cc=shawn.guo@linaro.org \
--cc=w.sang@pengutronix.de \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox