Re: [PATCH] mmc: sdhci-s3c: Remove old and misprototyped suspend operations

[Jaehoon Chung <jh80.chung@samsung.com>]

Hi Tushar.

I also tested this patch with Samsung-SoC.
But i didn't find the below message 
"mmc0: Timeout waiting for hardware interrupt."

I didn't understand what is that differ with previously code?
(just using dev_pm_ops..)

Thanks,
Jaehoon Chung

On 12/25/2011 11:29 AM, Chris Ball wrote:

> Hi,
> 
> On Mon, Dec 19 2011, Tushar Behera wrote:
>>>>> Now that the driver is using dev_pm_ops the suspend operations in the
>>>>> platform_driver structure won't get called so don't need to be there,
>>>>> and certainly shouldn't be the same function as dev_pm_ops since the
>>>>> signatures are different.
>>>>>
>>>>> Signed-off-by: Mark Brown <broonie <at> opensource.wolfsonmicro.com>
>>
>> On Origen board (based on EXYNOS4210), the primary filesystem is on a
>> SD/MMC card. When tested with v3.2-rc6 kernel, the system doesn't resume
>> properly.
>>
>> After resume, it keeps printing following message and the filesystem never
>> comes up.
>>
>> mmc0: Timeout waiting for hardware interrupt.
>>
>> If this patch is reverted, the system is able to mount the filesystem 
>> successfully.    
>>
>> Am I missing something?
> 
> Mark/Jaehoon?  This looks very bad.

> 
> - Chris.