* sdhci max_blk_size
@ 2012-01-04 15:01 Matthieu CASTET
2012-01-05 1:16 ` Aaron Lu
0 siblings, 1 reply; 3+ messages in thread
From: Matthieu CASTET @ 2012-01-04 15:01 UTC (permalink / raw)
To: linux-mmc@vger.kernel.org
Hi,
our controller set "Max Block Length" to 3 (4096 byte), but the linux driver
ignore this value [1].
Is there any reason to do that .
Or it is code that was written with an older sdhci spec, and we can ignore this
check today.
Matthieu
PS : please keep me in CC.
[1]
if (mmc->max_blk_size >= 3) {
pr_warning("%s: Invalid maximum block size, "
"assuming 512 bytes\n", mmc_hostname(mmc));
mmc->max_blk_size = 0;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: sdhci max_blk_size
2012-01-04 15:01 sdhci max_blk_size Matthieu CASTET
@ 2012-01-05 1:16 ` Aaron Lu
2012-01-05 12:46 ` Matthieu CASTET
0 siblings, 1 reply; 3+ messages in thread
From: Aaron Lu @ 2012-01-05 1:16 UTC (permalink / raw)
To: Matthieu CASTET; +Cc: linux-mmc@vger.kernel.org
On Wed, Jan 04, 2012 at 04:01:07PM +0100, Matthieu CASTET wrote:
> Hi,
>
> our controller set "Max Block Length" to 3 (4096 byte), but the linux driver
> ignore this value [1].
>
> Is there any reason to do that .
The reason is, sd host controller spec defines 3 as reserved, not 4096.
> Or it is code that was written with an older sdhci spec, and we can ignore this
> check today.
The current sdhci driver follows v3 spec, is the v4 spec out that
defined this bit?
>
>
>
> Matthieu
>
> PS : please keep me in CC.
>
> [1]
> if (mmc->max_blk_size >= 3) {
> pr_warning("%s: Invalid maximum block size, "
> "assuming 512 bytes\n", mmc_hostname(mmc));
> mmc->max_blk_size = 0;
> }
> --
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: sdhci max_blk_size
2012-01-05 1:16 ` Aaron Lu
@ 2012-01-05 12:46 ` Matthieu CASTET
0 siblings, 0 replies; 3+ messages in thread
From: Matthieu CASTET @ 2012-01-05 12:46 UTC (permalink / raw)
To: Aaron Lu; +Cc: linux-mmc@vger.kernel.org
Aaron Lu a écrit :
> On Wed, Jan 04, 2012 at 04:01:07PM +0100, Matthieu CASTET wrote:
>> Hi,
>>
>> our controller set "Max Block Length" to 3 (4096 byte), but the linux driver
>> ignore this value [1].
>>
>> Is there any reason to do that .
>
> The reason is, sd host controller spec defines 3 as reserved, not 4096.
ok, in fact this is an extension of our controller : it claims to be sdhci v2,
but they added extra registers and added some field in standard register.
For example they added 4K support by using bit 15 of Block size register.
I think we should use SDHCI_QUIRK_FORCE_BLK_SZ_2048.
Sorry for the mail.
Matthieu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-05 12:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-04 15:01 sdhci max_blk_size Matthieu CASTET
2012-01-05 1:16 ` Aaron Lu
2012-01-05 12:46 ` Matthieu CASTET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).