From: Heiko Schocher <hs@denx.de>
Cc: juha.kuikka@gmail.com, linux-mmc@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com, "Rajashekhara,
Sudhakar" <sudhakar.raj@ti.com>, Ido Yariv <ido@wizery.com>,
Sekhar Nori <nsekhar@ti.com>, Wolfgang Denk <wd@denx.de>,
Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH v2] arm, da8xx, mmc: set second MMC controllers default queue
Date: Wed, 11 Jan 2012 09:28:56 +0100 [thread overview]
Message-ID: <4F0D4848.4070000@denx.de> (raw)
In-Reply-To: <1323327357-23886-1-git-send-email-hs@denx.de>
Hello,
Heiko Schocher wrote:
> The MMC driver allocates channels with EVENTQ_DEFAULT, they
> get put into EVENTQ_1, which the second EDMA controller does
> not have and hence transfers stall. This is fixed
> in commit f23fe857bbea393b4b94fe2218c98d934bd3d4cf
> "ARM: davinci: Explicitly set channel controllers' default queues"
> from Ido Yariv. This patch sets immediately in edma_probe()
> the proper default_queue, so this patch does not really fix
> something, it is more a cosmetic change.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Signed-off-by: juha.kuikka@gmail.com
> Reported-by: juha.kuikka@gmail.com
> Acked-by: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
> Cc: linux-mmc@vger.kernel.org
> Cc: davinci-linux-open-source@linux.davincidsp.com
> Cc: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
> Cc: Ido Yariv <ido@wizery.com>
> Cc: Sekhar Nori <nsekhar@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Sergei Shtylyov <sshtylyov@mvista.com>
>
> ---
> - changes for v2:
> - add comment from Sergei Shtylyov
> add in commit message the commit's summary in parens.
> - add comment from Ido Yariv:
> changed comment and commit message
> - added Acked-by from Rajashekhara, Sudhakar
>
> arch/arm/mach-davinci/dma.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
Ping. Can this patch go into mainline, or are there some more objections?
Thanks
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2012-01-11 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 9:33 [PATCH] arm, da8xx, mmc: set second MMC controllers default queue Heiko Schocher
2011-12-04 12:15 ` Sergei Shtylyov
2011-12-04 13:25 ` Rajashekhara, Sudhakar
2011-12-05 10:46 ` Heiko Schocher
2011-12-06 19:09 ` Nori, Sekhar
2011-12-06 19:15 ` Hernandez, Alejandro
2011-12-08 6:55 ` [PATCH v2] " Heiko Schocher
2012-01-11 8:28 ` Heiko Schocher [this message]
2012-01-12 9:19 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0D4848.4070000@denx.de \
--to=hs@denx.de \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=ido@wizery.com \
--cc=juha.kuikka@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=sshtylyov@mvista.com \
--cc=sudhakar.raj@ti.com \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).