From: Viresh Kumar <viresh.kumar@st.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"perex@perex.cz" <perex@perex.cz>,
Vipin KUMAR <vipin.kumar@st.com>,
Mirko GARDI <mirko.gardi@st.com>,
Vincenzo FRASCINO <Vincenzo.FRASCINO@st.com>,
Pratyush ANAND <pratyush.anand@st.com>,
"vinod.koul@intel.com" <vinod.koul@intel.com>,
Deepak SIKRI <deepak.sikri@st.com>,
"cjb@laptop.org" <cjb@laptop.org>,
"hskinnemoen@gmail.com" <hskinnemoen@gmail.com>,
Bhavna YADAV <bhavna.yadav@st.com>,
Armando VISCONTI <armando.visconti@st.com>,
"egtvedt@samfundet.no" <egtvedt@samfundet.no>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Amit VIRDI <Amit.VIRDI@st.com>,
Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
Ulf HANSSON <ulf.hansson@stericsson.com>,
"linux-arm-kernel@lists.infradead.org" <linux-arm-k>
Subject: Re: [PATCH V2 08/12] dmaengine/dw_dmac: Unmap all memory buffers after completion of slave transfers
Date: Wed, 18 Jan 2012 15:24:44 +0530 [thread overview]
Message-ID: <4F1696E4.9070806@st.com> (raw)
In-Reply-To: <20120118093620.GC1068@n2100.arm.linux.org.uk>
On 1/18/2012 3:06 PM, Russell King - ARM Linux wrote:
> On Wed, Jan 18, 2012 at 02:41:55PM +0530, Viresh Kumar wrote:
> NAK. For reasons stated previously and subsequently ignored.
> .
>
On 1/18/2012 3:05 PM, Russell King - ARM Linux wrote:
>> > You implemented similar stuff in amba-pl08x :) .
>> >
>> > if (!plchan->slave)
>> > pl08x_unmap_buffers(txd);
> Take a look at that. "If *NOT* slave, unmap the buffers".
[Following is picked from current implementation of dw_dmac:]
if (!dwc->chan.private) {
struct device *parent = chan2parent(&dwc->chan);
if (!(txd->flags & DMA_COMPL_SKIP_DEST_UNMAP)) {
Sorry, I missed the most straight forward looking code. :(
Actually, dw_dmac is also doing the same, i.e. unmapping only for
non-slave transfers.
The same patch is still applicable, after fixing message subject and log.
I will resend it, with message log fixed, once i get more feedbacks on V2.
--
viresh
next prev parent reply other threads:[~2012-01-18 9:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 9:11 [PATCH V2 00/12] dmaengine: Pl08x and dw_dmac updates Viresh Kumar
2012-01-18 9:11 ` [PATCH V2 01/12] dmaengine/dw_dmac: Hibernation support in dw_dmac Viresh Kumar
2012-01-18 9:11 ` [PATCH V2 02/12] dmaengine: Add flow controller information to dma_slave_config Viresh Kumar
2012-01-19 16:59 ` Linus Walleij
2012-01-31 3:54 ` Vinod Koul
2012-01-31 3:55 ` Viresh Kumar
2012-01-18 9:11 ` [PATCH V2 03/12] dmaengine: Pass dma_slave_config .device_fc = NULL for all existing users Viresh Kumar
2012-01-19 17:00 ` Linus Walleij
2012-01-18 9:11 ` [PATCH V2 04/12] dmaengine/amba-pl08x: Take flow controller info from DMA_SLAVE_CONFIG Viresh Kumar
2012-01-19 17:01 ` Linus Walleij
2012-01-18 9:11 ` [PATCH V2 05/12] dmaengine/dw_dmac: Don't use magic number for total number of channels Viresh Kumar
2012-01-18 9:11 ` [PATCH V2 06/12] dmaengine/dw_dmac: Use dev_get_platdata() instead of accessing dev directly Viresh Kumar
2012-01-18 9:11 ` [PATCH V2 07/12] dmaengine/dw_dmac: Don't handle block interrupts Viresh Kumar
2012-01-18 9:11 ` [PATCH V2 08/12] dmaengine/dw_dmac: Unmap all memory buffers after completion of slave transfers Viresh Kumar
2012-01-18 9:36 ` Russell King - ARM Linux
2012-01-18 9:54 ` Viresh Kumar [this message]
2012-01-19 17:36 ` Linus Walleij
2012-01-31 3:58 ` Vinod Koul
2012-01-31 4:07 ` Viresh Kumar
2012-01-31 5:12 ` Vinod Koul
2012-01-31 5:19 ` Viresh Kumar
2012-01-31 5:36 ` Vinod Koul
2012-01-31 5:40 ` Viresh Kumar
2012-01-18 9:11 ` [PATCH V2 09/12] dmaengine/dw_dmac: Add 64 bit access width support for slave xfers on mem side Viresh Kumar
2012-01-18 9:11 ` [PATCH V2 10/12] dmaengine/dw_dmac: Add support for DMA_SLAVE_CONFIG Viresh Kumar
2012-01-18 9:11 ` [PATCH V2 11/12] dmaengine/dw_dmac: Fix dw_dmac user drivers to adapt to slave_config changes Viresh Kumar
2012-01-18 9:11 ` [PATCH V2 12/12] dmaengine/dw_dmac: Remove unused fields in struct dw_dma_slave Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1696E4.9070806@st.com \
--to=viresh.kumar@st.com \
--cc=Amit.VIRDI@st.com \
--cc=Vincenzo.FRASCINO@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=cjb@laptop.org \
--cc=dan.j.williams@intel.com \
--cc=deepak.sikri@st.com \
--cc=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux@arm.linux.org.uk \
--cc=mirko.gardi@st.com \
--cc=perex@perex.cz \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=ulf.hansson@stericsson.com \
--cc=vinod.koul@intel.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).