From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH V2 08/12] dmaengine/dw_dmac: Unmap all memory buffers after completion of slave transfers Date: Tue, 31 Jan 2012 09:37:54 +0530 Message-ID: <4F27691A.5010503@st.com> References: <20120118093620.GC1068@n2100.arm.linux.org.uk> <4F1696E4.9070806@st.com> <1327982312.1527.61.camel@vkoul-udesk3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1327982312.1527.61.camel@vkoul-udesk3> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Vinod Koul Cc: Rajeev KUMAR , Bhupesh SHARMA , "linus.walleij@linaro.org" , "perex@perex.cz" , Vipin KUMAR , Mirko GARDI , "egtvedt@samfundet.no" , Pratyush ANAND , Russell King - ARM Linux , Deepak SIKRI , "cjb@laptop.org" , "hskinnemoen@gmail.com" , Bhavna YADAV , Armando VISCONTI , Shiraz HASHIM , Amit VIRDI , Vincenzo FRASCINO , Vipul Kumar SAMAR , "dan.j.williams@intel.com" , Ulf HANSSON , "linux-arm-kernel@lists.infradead.org" List-Id: linux-mmc@vger.kernel.org On 1/31/2012 9:28 AM, Vinod Koul wrote: >> > if (!dwc->chan.private) { >> > struct device *parent = chan2parent(&dwc->chan); >> > if (!(txd->flags & DMA_COMPL_SKIP_DEST_UNMAP)) { >> > >> > Sorry, I missed the most straight forward looking code. :( >> > Actually, dw_dmac is also doing the same, i.e. unmapping only for >> > non-slave transfers. >> > >> > The same patch is still applicable, after fixing message subject and log. >> > I will resend it, with message log fixed, once i get more feedbacks on V2. >> > > But this patch seems to unmap for *all* descriptors, so you need to fix > that as well, apart from the ones stated above. What do you mean by *all* here? All type of transfers ? If that's the question, then the answer is NO. I am unmapping all descriptors of current transfer only for non-slave transfers. -- viresh