From: Adrian Hunter <adrian.hunter@intel.com>
To: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org, Philip Rakity <prakity@marvell.com>,
Aaron Lu <aaron.lu@amd.com>, Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH 2/2] mmc: sdhci: always reset all during resume
Date: Mon, 06 Feb 2012 15:14:47 +0200 [thread overview]
Message-ID: <4F2FD247.70004@intel.com> (raw)
In-Reply-To: <m2d39u84sm.fsf@bob.laptop.org>
On 05/02/12 03:09, Chris Ball wrote:
> This patch doesn't look correct to me -- yes, the hardware might have
> lost power during suspend, but that's what the common-case of:
>
> sdhci_init(host, soft=0);
>
> is for. soft=1 is supposed to indicate that the power stayed up via
> MMC_PM_KEEP_POWER, but you're changing that by setting ->pwr = 0 in the
> soft=1 path. If I'm using soft=1 because my controller has a wifi SDIO
> card on it, I don't want you to reprogram the power to it on resume.
> Does that make sense?
Yes, I will send a different patch (to handle the "card is on, but the host
controller is off" case)
prev parent reply other threads:[~2012-02-06 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 12:27 [PATCH 0/2] mmc: sdhci-pci: fixes for Medfield SDIO suspend / resume Adrian Hunter
2012-01-30 12:27 ` [PATCH 1/2] mmc: sdhci-pci: set Medfield SDIO as non-removable Adrian Hunter
2012-02-05 2:02 ` Chris Ball
2012-01-30 12:27 ` [PATCH 2/2] mmc: sdhci: always reset all during resume Adrian Hunter
2012-02-03 2:02 ` Aaron Lu
2012-02-05 1:09 ` Chris Ball
2012-02-05 2:09 ` Nicolas Pitre
2012-02-06 13:14 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2FD247.70004@intel.com \
--to=adrian.hunter@intel.com \
--cc=aaron.lu@amd.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).