[PATCH 3/4] mmc: sdhci-s3c: use the sdhci-s3c.h instead of regs-sdhci.h

[PATCH 3/4] mmc: sdhci-s3c: use the sdhci-s3c.h instead of regs-sdhci.h

[Jaehoon Chung]

Use the sdhci-s3c.h

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/mmc/host/sdhci-s3c.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index a651c1e..ac4b0e8 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -24,9 +24,9 @@
 #include <linux/mmc/host.h>
 
 #include <plat/sdhci.h>
-#include <plat/regs-sdhci.h>
 
 #include "sdhci-pltfm.h"
+#include "sdhci-s3c.h"
 #include "sdhci.h"
 
 #define MAX_BUS_CLK	(4)
@@ -200,14 +200,12 @@ static void sdhci_s3c_set_clock(struct sdhci_host *host, unsigned int clock)
 	}
 
 	/* reprogram default hardware configuration */
-	writel(S3C64XX_SDHCI_CONTROL4_DRIVE_9mA,
-		host->ioaddr + S3C64XX_SDHCI_CONTROL4);
+	writel(S3C_SDHCI_CONTROL4_DRIVE_9mA,
+		host->ioaddr + S3C_SDHCI_CONTROL4);
 
 	ctrl = readl(host->ioaddr + S3C_SDHCI_CONTROL2);
-	ctrl |= (S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR |
-		  S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK |
-		  S3C_SDHCI_CTRL2_ENFBCLKRX |
-		  S3C_SDHCI_CTRL2_DFCNT_NONE |
+	ctrl |= (S3C_SDHCI_CTRL2_ENSTAASYNCCLR | S3C_SDHCI_CTRL2_ENCMDCNFMSK |
+		  S3C_SDHCI_CTRL2_ENFBCLKRX | S3C_SDHCI_CTRL2_DFCNT_NONE |
 		  S3C_SDHCI_CTRL2_ENCLKOUTHOLD);
 	writel(ctrl, host->ioaddr + S3C_SDHCI_CONTROL2);
 

Re: [PATCH 3/4] mmc: sdhci-s3c: use the sdhci-s3c.h instead of regs-sdhci.h

[Kukjin Kim]

On 02/14/12 14:03, Jaehoon Chung wrote:
> Use the sdhci-s3c.h
>
This patch should be merged into 2nd patch which is including change the 
name to S3C_SDHCI_xxx from S3C64Xx_SDHCI_xxx. BTW, I'm not sure the name 
should/can be changed because as you know S3C64XX_ means this can be 
used after S3C64XX or just for S3C64XX, so need to check data sheet of 
SDHCI part for S3C24XX and S3C64XX and later.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Re: [PATCH 3/4] mmc: sdhci-s3c: use the sdhci-s3c.h instead of regs-sdhci.h

[Jae hoon Chung]

2012/2/16 Kukjin Kim <kgene.kim@samsung.com>:
> On 02/14/12 14:03, Jaehoon Chung wrote:
>>
>> Use the sdhci-s3c.h
>>
> This patch should be merged into 2nd patch which is including change the
> name to S3C_SDHCI_xxx from S3C64Xx_SDHCI_xxx. BTW, I'm not sure the name
> should/can be changed because as you know S3C64XX_ means this can be used
> after S3C64XX or just for S3C64XX, so need to check data sheet of SDHCI part
> for S3C24XX and S3C64XX and later.
Hi Mr. Kukjin.

I know that use only S3C64XX_ or S3C24XX.
But i think no problem that change to S3C_SDHCI_xxx form S3C64XX_SDHCI_xxx.
Because now that's meaningless...Though use the S3C64XX_SDHCI_xxx or S3C24xxx_,
finally that also use in sdhci-s3c.c.

What means that distinguish between S3C_SDHCI and S3C64xx_SDHCI?

Best Regards,
Jaehoon Chung

>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html