From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH 4/4] ARM: SAMSUNG: move the mmc platdata header file to linux/mmc/ Date: Thu, 16 Feb 2012 21:56:32 +0900 Message-ID: <4F3CFD00.6020909@samsung.com> References: <4F39EB0D.90905@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F39EB0D.90905@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Jaehoon Chung Cc: linux-mmc , linux-samsung-soc@vger.kernel.org, Chris Ball , Kyungmin Park , 'kgene kim' List-Id: linux-mmc@vger.kernel.org On 02/14/12 14:03, Jaehoon Chung wrote: > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin-park > --- > arch/arm/plat-samsung/include/plat/sdhci.h | 59 +------------------- > include/linux/mmc/sdhci-s3c.h | 84 ++++++++++++++++++++++++++++ > 2 files changed, 85 insertions(+), 58 deletions(-) > create mode 100644 include/linux/mmc/sdhci-s3c.h > Hi, I don't agree with this. Basically, the components(struct s3c_sdhci_platdata and some enums) you moved here are just for platform data on each board in arch/arm/. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.