From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: mmc: dw_mmc: fixed compile error when disable CONFIG_MMC_DW_IDMAC Date: Mon, 20 Feb 2012 12:10:08 +0000 Message-ID: <4F423820.10000@imgtec.com> References: <4F3C67BA.7040309@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from multi.imgtec.com ([194.200.65.239]:15775 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784Ab2BTMZZ (ORCPT ); Mon, 20 Feb 2012 07:25:25 -0500 In-Reply-To: <4F3C67BA.7040309@samsung.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Jaehoon Chung Cc: linux-mmc , Chris Ball , Kyungmin Park , Will Newton , Seungwon Jeon On 16/02/12 02:19, Jaehoon Chung wrote: > When disable CONFIG_MMC_DW_IDMAC, can see the compiler error. > Because in dw_mci_post_req(), called the dw_mci_get_dma_dir(). > But that function is in #ifdef CONFIG_MMC_DW_IDMAC. > > I think that function is generic function. > Not need the CONFIG_MMC_DW_IDMAC. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park Acked-by: James Hogan > --- > drivers/mmc/host/dw_mmc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index f9457e5..692c3ba 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -295,7 +295,6 @@ static void dw_mci_stop_dma(struct dw_mci *host) > } > } > > -#ifdef CONFIG_MMC_DW_IDMAC > static int dw_mci_get_dma_dir(struct mmc_data *data) > { > if (data->flags & MMC_DATA_WRITE) > @@ -304,6 +303,7 @@ static int dw_mci_get_dma_dir(struct mmc_data *data) > return DMA_FROM_DEVICE; > } > > +#ifdef CONFIG_MMC_DW_IDMAC > static void dw_mci_dma_cleanup(struct dw_mci *host) > { > struct mmc_data *data = host->data;