ANNOUNCE: new "mmc-utils" repository

ANNOUNCE: new "mmc-utils" repository

[Chris Ball]

Hi,

I've created a repository for userspace mmc tools now:

git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git

At the moment the only commands supported are Johan Rudholm's extcsd
write-protect commands, exposed as:

   ./mmc extcsd read /dev/mmcblkX
   ./mmc extcsd write /dev/mmcblkX

Johan, when I try running these I'm seeing:

octavius:cjb~/git/mmc-utils % sudo ./mmc extcsd read /dev/mmcblk0
sdhci-pci 0000:0d:00.0: mmc_blk_ioctl_cmd: cmd error -110
ioctl: Connection timed out
Could not read EXT_CSD from /dev/mmcblk0

Were you doing something to get the card back into idle state first,
perhaps?

Giuseppe, it would be excellent if you could add your ext_csd parsing
code to the "extcsd read" command.

Shashidhar, please could you separate out the kernel-side changes needed
for your test ioctl, and send a patch for kernelspace and one to add an
"mmc runcmd <cmd>" command to this tool?

Thanks everyone!  If anyone else has userspace mmc code to contribute,
feel free to hook it up to this tool and send patches to linux-mmc@.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: ANNOUNCE: new "mmc-utils" repository

[Linus Walleij]

On Sun, Feb 12, 2012 at 6:03 PM, Chris Ball <cjb@laptop.org> wrote:

> I've created a repository for userspace mmc tools now:
> git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git

Way to go Chris, this is great stuff!

Yours,
Linus Walleij

Re: ANNOUNCE: new "mmc-utils" repository

[Jaehoon Chung]

On 02/13/2012 02:03 AM, Chris Ball wrote:

> Hi,
> 
> I've created a repository for userspace mmc tools now:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git
> 
> At the moment the only commands supported are Johan Rudholm's extcsd
> write-protect commands, exposed as:
> 
>    ./mmc extcsd read /dev/mmcblkX
>    ./mmc extcsd write /dev/mmcblkX
> 
> Johan, when I try running these I'm seeing:
> 
> octavius:cjb~/git/mmc-utils % sudo ./mmc extcsd read /dev/mmcblk0
> sdhci-pci 0000:0d:00.0: mmc_blk_ioctl_cmd: cmd error -110
> ioctl: Connection timed out
> Could not read EXT_CSD from /dev/mmcblk0

I tested with SD and eMMC.
In eMMC case..

/opt/home/root # mmc extcsd read /dev/mmcblk0
Power ro locking: possible
Permanent ro locking: possible
ro lock status: not locked

But In SD card,
s3c-sdhci s3c-sdhci.2: mmc_blk_ioctl_cmd: cmd error -110
ioctl: Connection timed out
Could not read EXT_CSD from /dev/mmcblk1

What differ? Anyway..It's great about mmc-utils.

Best Regards,
Jaehoon Chung

> 
> Were you doing something to get the card back into idle state first,
> perhaps?
> 
> Giuseppe, it would be excellent if you could add your ext_csd parsing
> code to the "extcsd read" command.
> 
> Shashidhar, please could you separate out the kernel-side changes needed
> for your test ioctl, and send a patch for kernelspace and one to add an
> "mmc runcmd <cmd>" command to this tool?
> 
> Thanks everyone!  If anyone else has userspace mmc code to contribute,
> feel free to hook it up to this tool and send patches to linux-mmc@.
> 
> - Chris.

RE: ANNOUNCE: new "mmc-utils" repository

[Johan RUDHOLM]

Chris Ball wrote:

> Johan, when I try running these I'm seeing:
> 
> octavius:cjb~/git/mmc-utils % sudo ./mmc extcsd read /dev/mmcblk0
> sdhci-pci 0000:0d:00.0: mmc_blk_ioctl_cmd: cmd error -110
> ioctl: Connection timed out
> Could not read EXT_CSD from /dev/mmcblk0
> 
> Were you doing something to get the card back into idle state first,
> perhaps?

Thank you for giving the code a home!

Hmm... No, this works fine for me without doing anything special. Even when reading/writing from/to the card, it works fine. It is an eMMC, right?

Kind regards, Johan

RE: ANNOUNCE: new "mmc-utils" repository

[Johan RUDHOLM]

Jaehoon Chung wrote:

> On 02/13/2012 02:03 AM, Chris Ball wrote:
> 
> > Hi,
> >
> > I've created a repository for userspace mmc tools now:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git
> >
> > At the moment the only commands supported are Johan Rudholm's extcsd
> > write-protect commands, exposed as:
> >
> >    ./mmc extcsd read /dev/mmcblkX
> >    ./mmc extcsd write /dev/mmcblkX
> >
> > Johan, when I try running these I'm seeing:
> >
> > octavius:cjb~/git/mmc-utils % sudo ./mmc extcsd read /dev/mmcblk0
> > sdhci-pci 0000:0d:00.0: mmc_blk_ioctl_cmd: cmd error -110
> > ioctl: Connection timed out
> > Could not read EXT_CSD from /dev/mmcblk0
> 
> I tested with SD and eMMC.
> In eMMC case..
> 
> /opt/home/root # mmc extcsd read /dev/mmcblk0
> Power ro locking: possible
> Permanent ro locking: possible
> ro lock status: not locked
> 
> But In SD card,
> s3c-sdhci s3c-sdhci.2: mmc_blk_ioctl_cmd: cmd error -110
> ioctl: Connection timed out
> Could not read EXT_CSD from /dev/mmcblk1
> 
> What differ? Anyway..It's great about mmc-utils.

Yes, this is expected -- SD cards don't have the ext csd register.

Kind regards, Johan

Re: ANNOUNCE: new "mmc-utils" repository

[Jaehoon Chung]

On 02/14/2012 05:07 PM, Johan RUDHOLM wrote:

> Jaehoon Chung wrote:
> 
>> On 02/13/2012 02:03 AM, Chris Ball wrote:
>>
>>> Hi,
>>>
>>> I've created a repository for userspace mmc tools now:
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git
>>>
>>> At the moment the only commands supported are Johan Rudholm's extcsd
>>> write-protect commands, exposed as:
>>>
>>>    ./mmc extcsd read /dev/mmcblkX
>>>    ./mmc extcsd write /dev/mmcblkX
>>>
>>> Johan, when I try running these I'm seeing:
>>>
>>> octavius:cjb~/git/mmc-utils % sudo ./mmc extcsd read /dev/mmcblk0
>>> sdhci-pci 0000:0d:00.0: mmc_blk_ioctl_cmd: cmd error -110
>>> ioctl: Connection timed out
>>> Could not read EXT_CSD from /dev/mmcblk0
>>
>> I tested with SD and eMMC.
>> In eMMC case..
>>
>> /opt/home/root # mmc extcsd read /dev/mmcblk0
>> Power ro locking: possible
>> Permanent ro locking: possible
>> ro lock status: not locked
>>
>> But In SD card,
>> s3c-sdhci s3c-sdhci.2: mmc_blk_ioctl_cmd: cmd error -110
>> ioctl: Connection timed out
>> Could not read EXT_CSD from /dev/mmcblk1
>>
>> What differ? Anyway..It's great about mmc-utils.
> 
> Yes, this is expected -- SD cards don't have the ext csd register.

What kernel version is supported? up to linux-3.3? did you know?
Best Regards,
Jaehoon Chung

> 
> Kind regards, Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: ANNOUNCE: new "mmc-utils" repository

[Chris Ball]

Hi,

On Tue, Feb 14 2012, Johan RUDHOLM wrote:
> Thank you for giving the code a home!
>
> Hmm... No, this works fine for me without doing anything special. Even
> when reading/writing from/to the card, it works fine. It is an eMMC,
> right?

Ah, great!  I was testing with an SD because I didn't have an eMMC
nearby, thinking I'd be able to at least check the CSD transfer.
Thanks, all makes sense.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: ANNOUNCE: new "mmc-utils" repository

[Chris Ball]

Hi,

On Tue, Feb 14 2012, Jaehoon Chung wrote:
> What kernel version is supported? up to linux-3.3? did you know?

I think the only requirement is the command submission ioctl, so it
should work in every kernel from 3.0 onwards.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

RE: ANNOUNCE: new "mmc-utils" repository

[Johan RUDHOLM]

Hi Chris, Jaehoon,

Chris Ball wrote:

> 
> Hi,
> 
> On Tue, Feb 14 2012, Jaehoon Chung wrote:
> > What kernel version is supported? up to linux-3.3? did you know?
> 
> I think the only requirement is the command submission ioctl, so it
> should work in every kernel from 3.0 onwards.

Actually, to be able to write to the ext csd via the ioctl, "mmc: core: check for zero length ioctl data" is also required. I think this went into 3.3-rc1.

Kind regards, Johan

Re: ANNOUNCE: new "mmc-utils" repository

[Jaehoon Chung]

On 02/15/2012 12:31 AM, Johan RUDHOLM wrote:

> Hi Chris, Jaehoon,
> 
> Chris Ball wrote:
> 
>>
>> Hi,
>>
>> On Tue, Feb 14 2012, Jaehoon Chung wrote:
>>> What kernel version is supported? up to linux-3.3? did you know?
>>
>> I think the only requirement is the command submission ioctl, so it
>> should work in every kernel from 3.0 onwards.
> 
> Actually, to be able to write to the ext csd via the ioctl, "mmc: core: check for zero length ioctl data" is also required. I think this went into 3.3-rc1.

Hi..Chris, Johan.

I think that mmc extcsd read/write <device> is something wrong..
If mmc extcsd write /dev/mmcblk0, then boot area1/2 is power-on-write-protect. right?
And i ran mmc extcsd read /dev/mmcblk0, and i printed the ext_csd[174](BOOT_WP_STATUS)
That's always 0x0.

That means Boot-area1/2 is not protected.
In do_write_extcsd(), i think that check with BOOT_WP_STATUS[174] whether protected or not.
not BOOT_WP[173].

How think about?

I will send the patch for this.

Best Regards,
Jaehoon Chung

> 
> Kind regards, Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

RE: ANNOUNCE: new "mmc-utils" repository

[Johan RUDHOLM]

Hi Jaehoon,

Jaehoon Chung wrote:

> On 02/15/2012 12:31 AM, Johan RUDHOLM wrote:
> 
> > Hi Chris, Jaehoon,
> >
> > Chris Ball wrote:
> >
> >>
> >> Hi,
> >>
> >> On Tue, Feb 14 2012, Jaehoon Chung wrote:
> >>> What kernel version is supported? up to linux-3.3? did you know?
> >>
> >> I think the only requirement is the command submission ioctl, so it
> >> should work in every kernel from 3.0 onwards.
> >
> > Actually, to be able to write to the ext csd via the ioctl, "mmc:
> core: check for zero length ioctl data" is also required. I think this
> went into 3.3-rc1.
> 
> Hi..Chris, Johan.
> 
> I think that mmc extcsd read/write <device> is something wrong..
> If mmc extcsd write /dev/mmcblk0, then boot area1/2 is power-on-write-
> protect. right?
> And i ran mmc extcsd read /dev/mmcblk0, and i printed the
> ext_csd[174](BOOT_WP_STATUS)
> That's always 0x0.
> 
> That means Boot-area1/2 is not protected.
> In do_write_extcsd(), i think that check with BOOT_WP_STATUS[174]
> whether protected or not.
> not BOOT_WP[173].
> 
> How think about?

I'm not sure... BOOT_WP_STATUS[174] was added in version 4.5, in 4.41 we only have BOOT_WP[173]. I guess we should read 174 if we have a 4.5 card, from the 4.5 spec: "To verify boot region protection read BOOT_WP_STATUS[174].", I guess this has been added because it's possible to lock only one boot partition in 4.5?

The command works fine for my 4.41 card:

# /data/mmc extcsd read /dev/block/mmcblk0
Power ro locking: possible
Permanent ro locking: possible
ro lock status: not locked
# /data/mmc extcsd write /dev/block/mmcblk0
# /data/mmc extcsd read /dev/block/mmcblk0
Power ro locking: possible
Permanent ro locking: possible
ro lock status: locked until next power on

Kind regards, Johan

Re: ANNOUNCE: new "mmc-utils" repository

[Giuseppe CAVALLARO]

Hi Chris

On 2/12/2012 6:03 PM, Chris Ball wrote:
> Hi,
> 
> I've created a repository for userspace mmc tools now:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git
> 
> At the moment the only commands supported are Johan Rudholm's extcsd
> write-protect commands, exposed as:
> 
>    ./mmc extcsd read /dev/mmcblkX
>    ./mmc extcsd write /dev/mmcblkX


Is it worth now trying to add the logic behind the patch (mmc: debugfs:
parse ext_csd via debug_fs (v2)) I sent time ago to parse the EXT_CSD?
I can do that on mmc-utils if not yet done. Pls let me know.

Peppe

> 
> Johan, when I try running these I'm seeing:
> 
> octavius:cjb~/git/mmc-utils % sudo ./mmc extcsd read /dev/mmcblk0
> sdhci-pci 0000:0d:00.0: mmc_blk_ioctl_cmd: cmd error -110
> ioctl: Connection timed out
> Could not read EXT_CSD from /dev/mmcblk0
> 
> Were you doing something to get the card back into idle state first,
> perhaps?
> 
> Giuseppe, it would be excellent if you could add your ext_csd parsing
> code to the "extcsd read" command.
> 
> Shashidhar, please could you separate out the kernel-side changes needed
> for your test ioctl, and send a patch for kernelspace and one to add an
> "mmc runcmd <cmd>" command to this tool?
> 
> Thanks everyone!  If anyone else has userspace mmc code to contribute,
> feel free to hook it up to this tool and send patches to linux-mmc@.
> 
> - Chris.

Re: ANNOUNCE: new "mmc-utils" repository

[Chris Ball]

Hi,

On Wed, Feb 15 2012, Giuseppe CAVALLARO wrote:
> Hi Chris
>
> On 2/12/2012 6:03 PM, Chris Ball wrote:
>> Hi,
>> 
>> I've created a repository for userspace mmc tools now:
>> 
>> git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git
>> 
>> At the moment the only commands supported are Johan Rudholm's extcsd
>> write-protect commands, exposed as:
>> 
>>    ./mmc extcsd read /dev/mmcblkX
>>    ./mmc extcsd write /dev/mmcblkX
>
>
> Is it worth now trying to add the logic behind the patch (mmc: debugfs:
> parse ext_csd via debug_fs (v2)) I sent time ago to parse the EXT_CSD?
> I can do that on mmc-utils if not yet done. Pls let me know.

Yes, please.  (If you look farther down in the same message I did
mention adding it!)

I think you can add it all to mmc extcsd read, rather than introducing
a new command.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: ANNOUNCE: new "mmc-utils" repository

[Giuseppe CAVALLARO]

On 2/15/2012 2:35 PM, Chris Ball wrote:
> Hi,
> 
> On Wed, Feb 15 2012, Giuseppe CAVALLARO wrote:
>> Hi Chris
>>
>> On 2/12/2012 6:03 PM, Chris Ball wrote:
>>> Hi,
>>>
>>> I've created a repository for userspace mmc tools now:
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git
>>>
>>> At the moment the only commands supported are Johan Rudholm's extcsd
>>> write-protect commands, exposed as:
>>>
>>>    ./mmc extcsd read /dev/mmcblkX
>>>    ./mmc extcsd write /dev/mmcblkX
>>
>>
>> Is it worth now trying to add the logic behind the patch (mmc: debugfs:
>> parse ext_csd via debug_fs (v2)) I sent time ago to parse the EXT_CSD?
>> I can do that on mmc-utils if not yet done. Pls let me know.
> 
> Yes, please.  (If you look farther down in the same message I did
> mention adding it!)
> 
> I think you can add it all to mmc extcsd read, rather than introducing
> a new command.

Agree! I'll do that and provide a patch asap.

peppe

> 
> Thanks,
> 
> - Chris.

Re: ANNOUNCE: new "mmc-utils" repository

[Chris Ball]

Hi,

On Tue, Feb 14 2012, Johan RUDHOLM wrote:
> Actually, to be able to write to the ext csd via the ioctl, "mmc:
> core: check for zero length ioctl data" is also required. I think this
> went into 3.3-rc1.

I'm seeing a crash when trying to write to the ext_csd on 3.0, so it
sounds like we should send this fix to stable@ -- I'll do that shortly.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: ANNOUNCE: new "mmc-utils" repository

[Giuseppe CAVALLARO]

On 2/15/2012 2:43 PM, Giuseppe CAVALLARO wrote:
> On 2/15/2012 2:35 PM, Chris Ball wrote:
>> Hi,
>>
>> On Wed, Feb 15 2012, Giuseppe CAVALLARO wrote:
>>> Hi Chris
>>>
>>> On 2/12/2012 6:03 PM, Chris Ball wrote:
>>>> Hi,
>>>>
>>>> I've created a repository for userspace mmc tools now:
>>>>
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git
>>>>
>>>> At the moment the only commands supported are Johan Rudholm's extcsd
>>>> write-protect commands, exposed as:
>>>>
>>>>    ./mmc extcsd read /dev/mmcblkX
>>>>    ./mmc extcsd write /dev/mmcblkX
>>>
>>>
>>> Is it worth now trying to add the logic behind the patch (mmc: debugfs:
>>> parse ext_csd via debug_fs (v2)) I sent time ago to parse the EXT_CSD?
>>> I can do that on mmc-utils if not yet done. Pls let me know.
>>
>> Yes, please.  (If you look farther down in the same message I did
>> mention adding it!)
>>
>> I think you can add it all to mmc extcsd read, rather than introducing
>> a new command.
> 
> Agree! I'll do that and provide a patch asap.

Hello Chris

I've sent the patch to this mailing list.
I will try to do further improvements starting from this first patch,
especially to add new parsing conditions for all the register bits (that
can be done later according to what we actually need to expose and
parser and what you suggest).

Regards
peppe

> 
> peppe
> 
>>
>> Thanks,
>>
>> - Chris.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>