From: Adrian Hunter <adrian.hunter@intel.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Hanumath Prasad <hanumath.prasad@stericsson.com>,
Per FORLIN <per.forlin@stericsson.com>,
Sebastian Rasmussen <sebras@gmail.com>,
"Dong, Chuanxiao" <chuanxiao.dong@intel.com>,
"svenkatr@ti.com" <svenkatr@ti.com>,
Konstantin Dorfman <kdorfman@codeaurora.org>
Subject: Re: [PATCH v7] mmc: support BKOPS feature for eMMC
Date: Thu, 23 Feb 2012 11:05:16 +0200 [thread overview]
Message-ID: <4F46014C.6040303@intel.com> (raw)
In-Reply-To: <4F45A293.6060608@samsung.com>
On 23/02/12 04:21, Jaehoon Chung wrote:
> On 02/22/2012 11:11 PM, Adrian Hunter wrote:
>
>> On 20/01/12 08:48, Jaehoon Chung wrote:
>>> Enable eMMC background operations (BKOPS) feature.
>>>
>>> If URGENT_BKOPS is set after a response, note that BKOPS
>>> are required. After all I/O requests are finished, run
>>> BKOPS if required. Should read/write operations be requested
>>> during BKOPS, first issue HPI to interrupt the ongoing BKOPS
>>> and then service the request.
>>
>> You are leaving bkops running and releasing the host. Won't
>> that cause problems for other entry points to mmc services
>> e.g. system suspend (cache control, sleep etc), ioctl, sysfs,
>> etc
>
> I see. i will complement for your review.
Please cc me.
> Didn't you have the other comment?
Well, yes. I also suggest:
- don't use host->lock spin lock at all
- claim the host in the caller not in
mmc_start_bkops()
But the main issues are design issues not implementation.
i.e.
- always run bkops at level 3 before doing any
other requests - that requirement should probably
be implemented in core rather than the block driver
- do not release the host while bkops are running
And a new one:
- how do you know that trim/discard/sanitize will not
result in a need for bkops?
next prev parent reply other threads:[~2012-02-23 9:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 6:48 [PATCH v7] mmc: support BKOPS feature for eMMC Jaehoon Chung
2012-02-03 11:56 ` Jae hoon Chung
2012-02-13 2:07 ` Jaehoon Chung
2012-02-14 11:41 ` Saugata Das
2012-02-15 2:50 ` Jaehoon Chung
2012-02-21 9:00 ` Konstantin Dorfman
2012-02-21 14:21 ` Jae hoon Chung
2012-02-22 7:16 ` Jaehoon Chung
2012-02-22 14:11 ` Adrian Hunter
2012-02-23 2:21 ` Jaehoon Chung
2012-02-23 9:05 ` Adrian Hunter [this message]
2012-02-24 8:38 ` Jaehoon Chung
2012-02-24 11:43 ` Saugata Das
2012-02-24 12:57 ` Jae hoon Chung
2012-03-11 16:06 ` Konstantin Dorfman
2012-03-12 0:01 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F46014C.6040303@intel.com \
--to=adrian.hunter@intel.com \
--cc=chuanxiao.dong@intel.com \
--cc=cjb@laptop.org \
--cc=hanumath.prasad@stericsson.com \
--cc=jh80.chung@samsung.com \
--cc=kdorfman@codeaurora.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=per.forlin@stericsson.com \
--cc=sebras@gmail.com \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).