Re: [PATCH v3 0/4] mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file

[Jaehoon Chung <jh80.chung@samsung.com>]

On 03/07/2012 01:30 AM, Mark Brown wrote:

> On Tue, Mar 06, 2012 at 11:40:08PM +0900, Jae hoon Chung wrote:
>> 2012/3/6 Heiko Stübner <heiko@sntech.de>:
>>> Am Dienstag, 6. März 2012, 14:00:54 schrieb Mark Brown:
> 
>>>> This series will break S3C64xx, you've not touched it at all in the
>>>> update but it uses the same SDHCI controller.
> 
>>> This problem will probably also surface for the S3C2416 which also uses the
>>> same SDHCI controller.
> 
>> i didn't know why will break  on them. Could you explain to me?
>> Are there codes which affect S3C64XX and S3C24XX?
>> If i miss out something, let me know.
> 
> The same IP is present and used with the same driver on other Samsung
> SoCs.

Hi Mark.

I know that used with the same driver on other Samsung-SoCs(S3C64XX/S3C24XX..etc)
I just only used the interface in sdhci-pltfm.c. Nothing difference..
Why do you think that will break the other SoC?

Header file(/plat/regs-sdhci.h) also is only used in sdhci-s3c.c.
And the least portion is moved into /linux/mmc/. 
Then included "linux/mmc/sdhci-s3c.h" in plat/sdhci.h.

What's difference? 
If you can explain the more detail, i can understand.
But sorry, now i didn't accept your opinion.

Best Regards,
Jaehoon Chung