From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH] mmc: pxamci: Use DIV_ROUND_UP at appropriate places Date: Tue, 10 Apr 2012 09:14:00 +0530 Message-ID: <4F83AC80.1070204@st.com> References: <1334023210.16328.3.camel@phoenix> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from eu1sys200aog116.obsmtp.com ([207.126.144.141]:53430 "EHLO eu1sys200aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753391Ab2DJDpu (ORCPT ); Mon, 9 Apr 2012 23:45:50 -0400 In-Reply-To: <1334023210.16328.3.camel@phoenix> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Axel Lin Cc: "linux-kernel@vger.kernel.org" , Chris Ball , Anton Vorontsov , David Brown , "linux-mmc@vger.kernel.org" On 4/10/2012 7:30 AM, Axel Lin wrote: > Signed-off-by: Axel Lin > --- > drivers/mmc/host/pxamci.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c > index cb2dc0e..4b89e73 100644 > --- a/drivers/mmc/host/pxamci.c > +++ b/drivers/mmc/host/pxamci.c > @@ -190,7 +190,7 @@ static void pxamci_setup_data(struct pxamci_host *host, struct mmc_data *data) > clks = (unsigned long long)data->timeout_ns * host->clkrate; > do_div(clks, 1000000000UL); > timeout = (unsigned int)clks + (data->timeout_clks << host->clkrt); > - writel((timeout + 255) / 256, host->base + MMC_RDTO); > + writel(DIV_ROUND_UP(timeout, 256), host->base + MMC_RDTO); > > if (data->flags & MMC_DATA_READ) { > host->dma_dir = DMA_FROM_DEVICE; > @@ -636,7 +636,7 @@ static int pxamci_probe(struct platform_device *pdev) > /* > * Calculate minimum clock rate, rounding up. > */ > - mmc->f_min = (host->clkrate + 63) / 64; > + mmc->f_min = DIV_ROUND_UP(host->clkrate, 64); > mmc->f_max = (mmc_has_26MHz()) ? 26000000 : host->clkrate; > > pxamci_init_ocr(host); Reviewed-by: Viresh Kumar -- viresh