From: Shubhrajyoti <shubhrajyoti@ti.com>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-mmc@vger.kernel.org
Subject: Re: [RFC 0/8] DMA engine conversion
Date: Mon, 23 Apr 2012 20:57:20 +0530 [thread overview]
Message-ID: <4F9574D8.1000104@ti.com> (raw)
In-Reply-To: <CAMQu2gyQ3928VQ9Q9Y0mNiacB+br2oGezGCvhLXikbOTi-JR3Q@mail.gmail.com>
On Monday 23 April 2012 06:02 PM, Shilimkar, Santosh wrote:
>> conversion process is fairly straight forward - it's more or less:
>> > 1. add struct dma_chan * pointer to the private structure.
>> > 2. add allocation/freeing functions for the DMA engine channels.
>> > 3. convert the callbacks to match the DMA engine callback prototype.
>> > 4. add code to set the DMA engine channel configuration appropriately
>> > (avoiding any unnecessary calls) via dmaengine_slave_config().
>> > 5. add code to queue the transfer via dmaengine_prep_slave_sg() and
>> > dmaengine_submit().
>> > 6. omap_start_dma() becomes dma_async_issue_pending().
>> >
>> > drivers/spi/spi-omap2-mcspi.c | 186 +++++++++++++++++++++++++++++++++-------
>> > 1 files changed, 153 insertions(+), 33 deletions(-)
> The patch seems to be fine to me.
>
> Am looping Shubro in case he has any comment on "why element sync was used ?"
> and also to test the patch with more peripherals connected over SPI.
>
> Regards
> Santosh
Tested on omap4 ethernet and omap3 touchscreen
also did a spidev test.
Tested-by: Shubhrajyoti <shubhrajyoti@ti.com <mailto:shubhrajyoti@ti.com>>
prev parent reply other threads:[~2012-04-23 15:27 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 10:09 [RFC 0/8] DMA engine conversion for omap_hsmmc Russell King - ARM Linux
2012-04-18 10:10 ` [PATCH 1/8] ARM: OMAP: fix DMA vs memory ordering Russell King
2012-04-18 10:15 ` Felipe Balbi
2012-04-18 10:17 ` Russell King - ARM Linux
2012-04-18 10:18 ` Felipe Balbi
2012-04-18 10:26 ` Russell King - ARM Linux
2012-04-20 22:22 ` Tony Lindgren
2012-04-23 14:19 ` Russell King - ARM Linux
2012-04-23 14:27 ` Tony Lindgren
2012-04-23 14:35 ` Shilimkar, Santosh
2012-04-18 10:10 ` [PATCH 2/8] dmaengine: amba-pl08x: ensure physical channels are properly held Russell King
2012-04-18 10:19 ` Russell King - ARM Linux
2012-04-27 20:38 ` Linus Walleij
2012-04-27 21:41 ` Russell King - ARM Linux
2012-04-18 10:11 ` [PATCH 3/8] dmaengine: split out virtual channel DMA support from sa11x0 driver Russell King
2012-04-24 10:35 ` Laxman Dewangan
2012-04-24 10:50 ` Russell King - ARM Linux
2012-04-24 10:57 ` Laxman Dewangan
2012-04-18 10:11 ` [PATCH 4/8] dmaengine: add OMAP DMA engine driver Russell King
2012-04-18 10:11 ` [PATCH 5/8] mmc: omap_hsmmc: release correct resource Russell King
2012-04-20 22:23 ` Tony Lindgren
2012-04-20 22:59 ` Chris Ball
2012-04-21 2:35 ` Chris Ball
2012-04-21 9:48 ` Russell King - ARM Linux
2012-04-22 15:20 ` Chris Ball
2012-04-18 10:12 ` [PATCH 6/8] mmc: omap_hsmmc: add DMA engine support Russell King
2012-04-18 18:11 ` Tony Lindgren
2012-04-18 19:09 ` Russell King - ARM Linux
2012-04-18 19:53 ` Tony Lindgren
2012-04-18 10:12 ` [PATCH 7/8] mmc: omap_hsmmc: remove private DMA API implementation Russell King
2012-04-18 10:12 ` [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization Russell King
2012-04-18 15:23 ` T Krishnamoorthy, Balaji
2012-04-18 15:29 ` Russell King - ARM Linux
2012-04-18 15:35 ` T Krishnamoorthy, Balaji
2012-04-18 18:19 ` Tony Lindgren
2012-04-18 19:10 ` Russell King - ARM Linux
2012-04-18 19:55 ` Tony Lindgren
2012-04-18 19:42 ` Russell King - ARM Linux
2012-04-18 20:02 ` Tony Lindgren
2012-04-18 20:24 ` Russell King - ARM Linux
2012-04-18 21:01 ` Tony Lindgren
2012-04-18 21:16 ` Russell King - ARM Linux
2012-04-18 21:34 ` Tony Lindgren
2012-04-18 21:36 ` Russell King - ARM Linux
2012-04-19 1:39 ` Tony Lindgren
2012-04-19 17:43 ` Russell King - ARM Linux
2012-04-19 18:07 ` Tony Lindgren
2012-04-20 15:10 ` Russell King - ARM Linux
2012-04-20 15:26 ` Tony Lindgren
2012-04-20 15:37 ` Russell King - ARM Linux
2012-04-20 16:43 ` Tony Lindgren
2012-04-20 22:09 ` Russell King - ARM Linux
2012-04-20 22:21 ` Tony Lindgren
2012-04-20 16:50 ` Tony Lindgren
2012-04-23 14:14 ` Russell King - ARM Linux
2012-04-23 14:30 ` Tony Lindgren
2012-04-23 14:34 ` Russell King - ARM Linux
2012-04-23 11:46 ` [RFC 0/8] DMA engine conversion Russell King - ARM Linux
2012-04-23 12:32 ` Shilimkar, Santosh
2012-04-23 15:27 ` Shubhrajyoti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9574D8.1000104@ti.com \
--to=shubhrajyoti@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).