From: Ulf Hansson <ulf.hansson@stericsson.com>
To: Girish K S <girish.shivananjappa@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"patches@linaro.org" <patches@linaro.org>,
"saugata.das@linaro.org" <saugata.das@linaro.org>
Subject: Re: [PATCH v3 2/2] mmc4.5: host: poweroff notify rework
Date: Mon, 14 May 2012 09:20:37 +0200 [thread overview]
Message-ID: <4FB0B245.7000206@stericsson.com> (raw)
In-Reply-To: <1336398084-23203-2-git-send-email-girish.shivananjappa@linaro.org>
Hi Girish,
In patch 1/2 you break the compilation of these host drivers. In this
patch 2/2 you fix it again. I would prefer you include these fixes in
the same patch instead of splitting them into two pieces.
Kind regards
Ulf Hansson
On 05/07/2012 03:41 PM, Girish K S wrote:
> This patch changes the structure member name to maintain consistency
> of name for the poweroff notify feature
>
> Signed-off-by: Girish K S<girish.shivananjappa@linaro.org>
> ---
> drivers/mmc/host/dw_mmc.c | 4 ++--
> drivers/mmc/host/sdhci.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index ab3fc46..09ac734 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1791,9 +1791,9 @@ static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
> mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
>
> if (mmc->caps2& MMC_CAP2_POWEROFF_NOTIFY)
> - mmc->power_notify_type = MMC_HOST_PW_NOTIFY_SHORT;
> + mmc->poweroff_notify_type = MMC_HOST_PW_OFF_NOTIFY_SHORT;
> else
> - mmc->power_notify_type = MMC_HOST_PW_NOTIFY_NONE;
> + mmc->poweroff_notify_type = MMC_HOST_PW_OFF_NOTIFY_NONE;
>
> if (host->pdata->blk_settings) {
> mmc->max_segs = host->pdata->blk_settings->max_segs;
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index e626732..958e5fe 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2817,9 +2817,9 @@ int sdhci_add_host(struct sdhci_host *host)
> * set notify to short power off notify timeout value.
> */
> if (mmc->caps2& MMC_CAP2_POWEROFF_NOTIFY)
> - mmc->power_notify_type = MMC_HOST_PW_NOTIFY_SHORT;
> + mmc->poweroff_notify_type = MMC_HOST_PW_OFF_NOTIFY_SHORT;
> else
> - mmc->power_notify_type = MMC_HOST_PW_NOTIFY_NONE;
> + mmc->poweroff_notify_type = MMC_HOST_PW_OFF_NOTIFY_NONE;
>
> /* Initial value for re-tuning timer count */
> host->tuning_count = (caps[1]& SDHCI_RETUNING_TIMER_COUNT_MASK)>>
next prev parent reply other threads:[~2012-05-14 7:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 13:41 [PATCH v3 1/2] MMC-4.5 Power OFF Notify rework Girish K S
2012-05-07 13:41 ` [PATCH v3 2/2] mmc4.5: host: poweroff notify rework Girish K S
2012-05-14 7:20 ` Ulf Hansson [this message]
2012-05-14 8:56 ` Girish K S
2012-05-14 9:00 ` Girish K S
2012-05-11 11:44 ` [PATCH v3 1/2] MMC-4.5 Power OFF Notify rework Subhash Jadavani
2012-05-14 6:32 ` Saugata Das
2012-05-14 8:49 ` Ulf Hansson
2012-05-14 9:48 ` Saugata Das
2012-05-14 11:15 ` Ulf Hansson
2012-05-14 12:49 ` Saugata Das
2012-05-14 13:26 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB0B245.7000206@stericsson.com \
--to=ulf.hansson@stericsson.com \
--cc=girish.shivananjappa@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=saugata.das@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox